You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lens.apache.org by jd...@apache.org on 2015/03/03 08:12:40 UTC

incubator-lens git commit: LENS-368 TestResultFormatting.testPersistentResultWithMaxSize fails intermittently (Amareshwari via jdhok)

Repository: incubator-lens
Updated Branches:
  refs/heads/master 1f33b5025 -> 8c86c9b29


LENS-368 TestResultFormatting.testPersistentResultWithMaxSize fails intermittently (Amareshwari via jdhok)


Project: http://git-wip-us.apache.org/repos/asf/incubator-lens/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-lens/commit/8c86c9b2
Tree: http://git-wip-us.apache.org/repos/asf/incubator-lens/tree/8c86c9b2
Diff: http://git-wip-us.apache.org/repos/asf/incubator-lens/diff/8c86c9b2

Branch: refs/heads/master
Commit: 8c86c9b298afa455b22161bfcd0334ab2aab96c5
Parents: 1f33b50
Author: jdhok <ja...@inmobi.com>
Authored: Tue Mar 3 12:42:27 2015 +0530
Committer: jdhok <ja...@inmobi.com>
Committed: Tue Mar 3 12:42:27 2015 +0530

----------------------------------------------------------------------
 .../org/apache/lens/server/query/TestResultFormatting.java     | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-lens/blob/8c86c9b2/lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java
----------------------------------------------------------------------
diff --git a/lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java b/lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java
index a0abb0a..0a4bb74 100644
--- a/lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java
+++ b/lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java
@@ -230,13 +230,13 @@ public class TestResultFormatting extends LensJerseyTest {
     if (status.equals(QueryStatus.Status.SUCCESSFUL)) {
       QueryContext qctx = queryService.getQueryContext(handle);
       if (qctx == null) {
-        // This shouldn't occur. But seems like this is appearing intermittently. So adding extra logs
+        // This shouldn't occur. It is appearing when query gets purged. So adding extra logs
         // for debugging in the future.
         LOG.info("successful query's QueryContext is null");
         LOG.info("query handle: " + handle);
         LOG.info("allQueries: " + queryService.allQueries);
-      }
-      if (!isDir) {
+        // not doing formatter validation if qctx is null
+      } else if (!isDir) {
         // isDir is true if the formatter is skipped due to result being the max size allowed
         if (qctx.isDriverPersistent()) {
           Assert.assertTrue(qctx.getQueryOutputFormatter() instanceof PersistedOutputFormatter);