[GitHub] [incubator-yunikorn-site] yangwwei commented on a change in pull request #14: [YUNIKORN-283] Support query params to filter the apps..

[GitBox <gi...@apache.org>]

yangwwei commented on a change in pull request #14:
URL: https://github.com/apache/incubator-yunikorn-site/pull/14#discussion_r466596999



##########
File path: docs/api/scheduler.md
##########
@@ -85,6 +85,12 @@ Displays general information about the applications like used resources, queue n
 
 **Method** : `GET`
 
+**Query Params** : 
+
+1. queue=<fully qualified queue name\>
+
+Fully qualified queue name filters the applications based on exact match. Passing only leaf queue name doesn't give the expected behaviour. For example, /ws/v1/apps?queue=root.default return the applications running in "root.default" queue.

Review comment:
       > Passing only leaf queue name doesn't give the expected behaviour.
   
   Not completely sure what does this mean. Can you pls refine the text.

##########
File path: docs/api/scheduler.md
##########
@@ -85,6 +85,12 @@ Displays general information about the applications like used resources, queue n
 
 **Method** : `GET`
 
+**Query Params** : 
+
+1. queue=<fully qualified queue name\>

Review comment:
       is \> necessary? or just > is fine here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org