You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by kirklund <gi...@git.apache.org> on 2016/11/01 21:42:29 UTC

[GitHub] incubator-geode pull request #278: Feature/geode 1896 unable to specify a Pa...

Github user kirklund commented on a diff in the pull request:

    https://github.com/apache/incubator-geode/pull/278#discussion_r86031904
  
    --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java ---
    @@ -31,19 +31,13 @@
     import javax.management.MalformedObjectNameException;
     import javax.management.ObjectName;
     
    +import joptsimple.internal.Strings;
    --- End diff --
    
    Let's avoid using internal APIs of 3rd party libraries. Looking down, I see that you're using Strings.isNullOrEmpty. We have a comparable method in org.apache.geode.internal.lang.StringUtils. Please change code from using Strings.isNullOrEmpty to StringUtils.isBlank.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---