You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by josephw <gi...@git.apache.org> on 2014/06/10 15:58:06 UTC
[GitHub] struts pull request: Fix a few NullPointerExceptions identified by...
GitHub user josephw opened a pull request:
https://github.com/apache/struts/pull/15
Fix a few NullPointerExceptions identified by Eclipse
Eclipse's static analysis of nulls identifies a number of spots where a `NullPointerException` can occur. This change fixes them either to rearrange things so they can't happen or to throw a more specific exception.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/josephw/struts master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/struts/pull/15.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15
----
commit 81cdd6e0d8fe01616e5c3055e5536ee63199b6e6
Author: Joseph Walton <jw...@atlassian.com>
Date: 2014-06-10T12:21:39Z
Clean up potential NullPointerExceptions.
- Construct BufferedReaders ahead of try blocks
- Don't catch exceptions in tests
- Specifically check for mismatched braces in patterns
- Fail on an unknown numeric type
commit f98e92c154add1c869efe88ce1fdba984a5f71aa
Author: Joseph Walton <jw...@atlassian.com>
Date: 2014-06-10T12:21:55Z
Fix potential NullPointerExceptions.
- Allow for a null location when logging
- Don't try to use a null LocationFinder
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: Fix a few NullPointerExceptions identified by...
Posted by josephw <gi...@git.apache.org>.
Github user josephw closed the pull request at:
https://github.com/apache/struts/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: Fix a few NullPointerExceptions identified by...
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/15#issuecomment-45664015
Two issues with this PR:
- open a JIRA ticket and reference this PR from it
- open PR against `develop` branch, not `master`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org