[jira] [Issue Comment Deleted] (KAFKA-3692) Wildcards in External CLASSPATH may cause it not be included in the CLASSPATH

["Ewen Cheslack-Postava (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-3692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ewen Cheslack-Postava updated KAFKA-3692:
-----------------------------------------
    Comment: was deleted

(was: More specifically, this was not an issue previously when we just used the external classpath. But a test was recently added to see if it is empty:

{code}
if [ -z $CLASSPATH ] ; then
  CLASSPATH=$dir/*
{code}

In this case (apparently) we need quoting or it can clobber the external classpath:

{code}
if [ -z "$CLASSPATH" ] ; then
  CLASSPATH="$dir"/*
{code})

> Wildcards in External CLASSPATH may cause it not be included in the CLASSPATH
> -----------------------------------------------------------------------------
>
>                 Key: KAFKA-3692
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3692
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.10.0.0
>            Reporter: Liquan Pei
>            Assignee: Liquan Pei
>             Fix For: 0.10.0.1
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently, we doesn't use double quote when using CLASSPATH in kafka-run-class.sh. This could potentially cause issues as spaces in external CLASSPATH may result in the CLASSPATH to be  incorrectly interpreted. As we perform a check on whether CLASSPATH is provided to determine the initial value of  CLASSPATH, not using double quotes may cause the external CLASSPATH not be included in the final CLASSPATH. We can workaround this by double quoting the external CLASSPATH, but it is a good practice to use double quotes if we are unsure.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)