You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2020/12/05 13:16:32 UTC
[royale-asjs] branch develop updated (a2fc29b -> 10d3a25)
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git.
from a2fc29b Jewel ListView: Fix issue where making dataProvider = null to any component which is using ListView bead causes NPE
new 68189a9 jewel-numericstepper: Jewel NumericStepper Value Property Fails Binding (fix #985)
new 10d3a25 tour-de-jewel: add jewel numericstepper binding test
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../src/main/royale/NumericStepperPlayGround.mxml | 16 ++++++++++++++++
.../jewel/beads/controllers/NumericStepperController.as | 13 ++++++++-----
.../org/apache/royale/jewel/beads/models/RangeModel.as | 3 +--
.../royale/jewel/beads/views/NumericStepperView.as | 9 +++++++--
4 files changed, 32 insertions(+), 9 deletions(-)
[royale-asjs] 02/02: tour-de-jewel: add jewel numericstepper
binding test
Posted by ca...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit 10d3a25c822564ac9ceb87d8814495ad77507c55
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Sat Dec 5 14:16:17 2020 +0100
tour-de-jewel: add jewel numericstepper binding test
---
.../src/main/royale/NumericStepperPlayGround.mxml | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/examples/jewel/TourDeJewel/src/main/royale/NumericStepperPlayGround.mxml b/examples/jewel/TourDeJewel/src/main/royale/NumericStepperPlayGround.mxml
index c3e87dc..793188c 100644
--- a/examples/jewel/TourDeJewel/src/main/royale/NumericStepperPlayGround.mxml
+++ b/examples/jewel/TourDeJewel/src/main/royale/NumericStepperPlayGround.mxml
@@ -28,9 +28,16 @@ limitations under the License.
private function valueChangeHandler(event:Event):void {
result.text = "Default NumericStepper: " + numericStepper.value;
}
+
+ [Bindable]
+ public var someBindableValue:Number = 5;
]]>
</fx:Script>
+ <c:beads>
+ <js:ContainerDataBinding />
+ </c:beads>
+
<j:Grid gap="true" itemsVerticalAlign="itemsSameHeight">
<j:beads>
<js:Paddings paddingTop="0" paddingLeft="50" paddingRight="50" paddingBottom="50"/>
@@ -65,6 +72,15 @@ limitations under the License.
<j:NumericStepper stepSize="2"/>
<j:Label text="NumericStepper stepSize='2'"/>
</j:HGroup>
+
+ <j:HGroup gap="3" itemsVerticalAlign="itemsCenter">
+ <j:NumericStepper stepSize="1"
+ minimum="0"
+ maximum="999"
+ value="{someBindableValue}" />
+ <j:Label text="NumericStepper value data binding"/>
+ </j:HGroup>
+
</j:Card>
</j:GridCell>
[royale-asjs] 01/02: jewel-numericstepper: Jewel NumericStepper
Value Property Fails Binding (fix #985)
Posted by ca...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit 68189a9e32904e644e21fb281a22ce38309e4acf
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Sat Dec 5 14:15:43 2020 +0100
jewel-numericstepper: Jewel NumericStepper Value Property Fails Binding (fix #985)
---
.../jewel/beads/controllers/NumericStepperController.as | 13 ++++++++-----
.../org/apache/royale/jewel/beads/models/RangeModel.as | 3 +--
.../apache/royale/jewel/beads/views/NumericStepperView.as | 9 +++++++--
3 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/NumericStepperController.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/NumericStepperController.as
index c2eddf9..0e556f5 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/NumericStepperController.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/NumericStepperController.as
@@ -96,12 +96,15 @@ package org.apache.royale.jewel.beads.controllers
// as resizing the component
spinner.addEventListener("valueChange", spinnerValueChanged);
+ var model:IRangeModel = _strand.getBeadByType(IRangeModel) as IRangeModel;
+
// listen for changes and update the UI accordingly
- listenOnStrand("valueChange", modelChangeHandler);
- listenOnStrand("minimumChange", modelChangeHandler);
- listenOnStrand("maximumChange", modelChangeHandler);
- listenOnStrand("stepSizeChange", modelChangeHandler);
- listenOnStrand("snapIntervalChange", modelChangeHandler);
+ model.addEventListener("valueChange", modelChangeHandler);
+ model.addEventListener("minimumChange", modelChangeHandler);
+ model.addEventListener("maximumChange", modelChangeHandler);
+ model.addEventListener("stepSizeChange", modelChangeHandler);
+ model.addEventListener("snapIntervalChange", modelChangeHandler);
+
}
/**
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/models/RangeModel.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/models/RangeModel.as
index 76e2c45..506b5f5 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/models/RangeModel.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/models/RangeModel.as
@@ -19,8 +19,8 @@
package org.apache.royale.jewel.beads.models
{
import org.apache.royale.core.IBead;
- import org.apache.royale.core.IStrand;
import org.apache.royale.core.IRangeModel;
+ import org.apache.royale.core.IStrand;
import org.apache.royale.events.Event;
import org.apache.royale.events.EventDispatcher;
import org.apache.royale.events.ValueChangeEvent;
@@ -197,7 +197,6 @@ package org.apache.royale.jewel.beads.models
{
return _value;
}
-
public function set value(newValue:Number):void
{
if (newValue != _value)
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/NumericStepperView.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/NumericStepperView.as
index d2fe531..8a6c309 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/NumericStepperView.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/NumericStepperView.as
@@ -24,9 +24,11 @@ package org.apache.royale.jewel.beads.views
import org.apache.royale.core.ILayoutChild;
import org.apache.royale.core.IParent;
import org.apache.royale.core.IParentIUIBase;
+ import org.apache.royale.core.IRangeModel;
import org.apache.royale.core.IStrand;
import org.apache.royale.core.IUIBase;
import org.apache.royale.core.UIBase;
+ import org.apache.royale.events.Event;
import org.apache.royale.jewel.Label;
import org.apache.royale.jewel.Spinner;
import org.apache.royale.jewel.TextInput;
@@ -75,7 +77,7 @@ package org.apache.royale.jewel.beads.views
override public function set strand(value:IStrand):void
{
super.strand = value;
-
+
// add an input field
input = new TextInput();
(value as IParent).addElement(input);
@@ -93,7 +95,10 @@ package org.apache.royale.jewel.beads.views
(value as IParent).addElement(spinnerview.increment as IChild);
(value as IParent).addElement(spinnerview.decrement as IChild);
- input.text = String(spinner.value);
+ var model:IRangeModel = _strand.getBeadByType(IRangeModel) as IRangeModel;
+ trace(model, model.value);
+ spinner.value = model.value;
+ input.text = String(model.value);
initSize();