You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/08 23:31:05 UTC

[GitHub] [tvm] csullivan commented on pull request #13325: [TRANSFORM] Fix virtual device annotation issue with BYOC subgraphs

csullivan commented on PR #13325:
URL: https://github.com/apache/tvm/pull/13325#issuecomment-1307976117

   Hi @srkreddy1238, I didn't quite understand the conclusion you make,  
   
   > PushVirtualDevice and PopVirtualDevice occurs as pairs across function body, **hence it's better to insert the The Virtual Device for Uncontrained and Pop it subsequently**
   
   Naively I can understand why we skip pushing an unconstrained virtual device: If something is fully unconstrained then it's virtual device shouldn't influence the function body visitation. What issue is this causing in BYOC? 
   
   Is there a unit test you can consider contributing that can help illustrate the issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org