You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/03/02 23:25:31 UTC
[GitHub] [airflow] potiuk opened a new pull request, #29888: Move help message to the google auth code
potiuk opened a new pull request, #29888:
URL: https://github.com/apache/airflow/pull/29888
The "google-auth" 2.16.2 just released, removed the _HELP_MESSAGE that was imported by google provider auth util thus failing the imports in canary builds of ours attempting to upgrade to newver versions of released libraries.
This PR inlines the original help message into our code to make it independent from google-auth package version used.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #29888: Move help message to the google auth code
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #29888:
URL: https://github.com/apache/airflow/pull/29888#issuecomment-1452928059
I wonder if we should just move all the underscore variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29888: Move help message to the google auth code
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29888:
URL: https://github.com/apache/airflow/pull/29888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29888: Move help message to the google auth code
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29888:
URL: https://github.com/apache/airflow/pull/29888#issuecomment-1453286774
Oups. I merged a bit too much. Will remove the code from _vendor that was accidentally added here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #29888: Move help message to the google auth code
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #29888: Move help message to the google auth code
URL: https://github.com/apache/airflow/pull/29888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #29888: Move help message to the google auth code
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed pull request #29888: Move help message to the google auth code
URL: https://github.com/apache/airflow/pull/29888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29888: Move help message to the google auth code
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29888:
URL: https://github.com/apache/airflow/pull/29888#issuecomment-1452721246
Should fix failing "canary" main build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29888: Move help message to the google auth code
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29888:
URL: https://github.com/apache/airflow/pull/29888#issuecomment-1453291305
#29895 removes the accidental additions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29888: Move help message to the google auth code
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29888:
URL: https://github.com/apache/airflow/pull/29888#issuecomment-1453119981
inlined all the constants now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29888: Move help message to the google auth code
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29888:
URL: https://github.com/apache/airflow/pull/29888#issuecomment-1453285505
merged @eladkal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #29888: Move help message to the google auth code
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #29888:
URL: https://github.com/apache/airflow/pull/29888#issuecomment-1453118275
> I wonder if we should just move all the underscore variables.
Yeah. I was on the fence with this one, but I realized this is far more than our test's problem. Right now if anyone uses old google provider with the new google auth, it will miserably fail, so the risk of having the imports are far bigger than inlining all the imports there. cc: @eladkal - this one SHOULD be included in the new wave of providers, as soon we might be flooded with "google provider stopped working" and we will have no other workarounds for those users but "downgrade google-auth package to 2.16.1. When we release this in the provider, we will also be able to tell them "upgrade google provider".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #29888: Move help message to the google auth code
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #29888:
URL: https://github.com/apache/airflow/pull/29888#issuecomment-1453137680
> cc: @eladkal - this one SHOULD be included in the new wave of providers
Ok waiting for merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org