You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Shawn Jiang (JIRA)" <ji...@apache.org> on 2011/01/10 03:18:47 UTC

[jira] Created: (WINK-330) Change slf4j api import to a range to make it more user friendly.

Change slf4j api import to a range to make it more user friendly.
-----------------------------------------------------------------

                 Key: WINK-330
                 URL: https://issues.apache.org/jira/browse/WINK-330
             Project: Wink
          Issue Type: Improvement
          Components: Build
    Affects Versions: 1.1.2
            Reporter: Shawn Jiang


Current slf4j import in wink bundles was binded to1.6.1 because of maven-bundle-plugin genereate the manefest file based on maven dependency.  This in turn will force any wink user in OSGi environment upgrade their slf4j to 1.6.1.    

This is not easy in some cases.   As you know,  many OSGi users(including geronimo) are using PAX-logging as log bridge to OSGi log service.  The slf4j export version in PAX-logging is 1.5.3.

If wink could change the slf4j import to  a range with a lower starting version.   It would be more OSGi user friendly.   Following is an example with wink-common module.  Please review it.

If you agree, I will open a JIRA and attach a complete patch for it.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WINK-330) Change slf4j api import to a range to make it more user friendly.

Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WINK-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979906#action_12979906 ] 

Shawn Jiang commented on WINK-330:
----------------------------------

Thanks Bryant,   could you help push a new wink snapshot to apache.snapshot repo so that we could pick it up in our CI system ?

> Change slf4j api import to a range to make it more user friendly.
> -----------------------------------------------------------------
>
>                 Key: WINK-330
>                 URL: https://issues.apache.org/jira/browse/WINK-330
>             Project: Wink
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.1.2
>            Reporter: Shawn Jiang
>            Assignee: Bryant Luk
>         Attachments: 0001-WINK-330-Change-slf4j-api-import-to-a-range-to-make-.patch
>
>
> Current slf4j import in wink bundles was binded to1.6.1 because of maven-bundle-plugin genereate the manefest file based on maven dependency.  This in turn will force any wink user in OSGi environment upgrade their slf4j to 1.6.1.    
> This is not easy in some cases.   As you know,  many OSGi users(including geronimo) are using PAX-logging as log bridge to OSGi log service.  The slf4j export version in PAX-logging is 1.5.3.
> If wink could change the slf4j import to  a range with a lower starting version.   It would be more OSGi user friendly.   Following is an example with wink-common module.  Please review it.
> If you agree, I will open a JIRA and attach a complete patch for it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WINK-330) Change slf4j api import to a range to make it more user friendly.

Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WINK-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shawn Jiang updated WINK-330:
-----------------------------

    Attachment: 0001-WINK-330-Change-slf4j-api-import-to-a-range-to-make-.patch

> Change slf4j api import to a range to make it more user friendly.
> -----------------------------------------------------------------
>
>                 Key: WINK-330
>                 URL: https://issues.apache.org/jira/browse/WINK-330
>             Project: Wink
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.1.2
>            Reporter: Shawn Jiang
>         Attachments: 0001-WINK-330-Change-slf4j-api-import-to-a-range-to-make-.patch
>
>
> Current slf4j import in wink bundles was binded to1.6.1 because of maven-bundle-plugin genereate the manefest file based on maven dependency.  This in turn will force any wink user in OSGi environment upgrade their slf4j to 1.6.1.    
> This is not easy in some cases.   As you know,  many OSGi users(including geronimo) are using PAX-logging as log bridge to OSGi log service.  The slf4j export version in PAX-logging is 1.5.3.
> If wink could change the slf4j import to  a range with a lower starting version.   It would be more OSGi user friendly.   Following is an example with wink-common module.  Please review it.
> If you agree, I will open a JIRA and attach a complete patch for it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WINK-330) Change slf4j api import to a range to make it more user friendly.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WINK-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980203#action_12980203 ] 

Hudson commented on WINK-330:
-----------------------------

Integrated in Wink-Trunk-JDK1.5 #429 (See [https://hudson.apache.org/hudson/job/Wink-Trunk-JDK1.5/429/])
    

> Change slf4j api import to a range to make it more user friendly.
> -----------------------------------------------------------------
>
>                 Key: WINK-330
>                 URL: https://issues.apache.org/jira/browse/WINK-330
>             Project: Wink
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.1.2
>            Reporter: Shawn Jiang
>            Assignee: Bryant Luk
>         Attachments: 0001-WINK-330-Change-slf4j-api-import-to-a-range-to-make-.patch
>
>
> Current slf4j import in wink bundles was binded to1.6.1 because of maven-bundle-plugin genereate the manefest file based on maven dependency.  This in turn will force any wink user in OSGi environment upgrade their slf4j to 1.6.1.    
> This is not easy in some cases.   As you know,  many OSGi users(including geronimo) are using PAX-logging as log bridge to OSGi log service.  The slf4j export version in PAX-logging is 1.5.3.
> If wink could change the slf4j import to  a range with a lower starting version.   It would be more OSGi user friendly.   Following is an example with wink-common module.  Please review it.
> If you agree, I will open a JIRA and attach a complete patch for it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WINK-330) Change slf4j api import to a range to make it more user friendly.

Posted by "Bryant Luk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WINK-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryant Luk resolved WINK-330.
-----------------------------

    Resolution: Fixed
      Assignee: Bryant Luk

Looks good.  I applied the patch and made the commit.  If you see any other issues, let us know.  Thanks!

> Change slf4j api import to a range to make it more user friendly.
> -----------------------------------------------------------------
>
>                 Key: WINK-330
>                 URL: https://issues.apache.org/jira/browse/WINK-330
>             Project: Wink
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.1.2
>            Reporter: Shawn Jiang
>            Assignee: Bryant Luk
>         Attachments: 0001-WINK-330-Change-slf4j-api-import-to-a-range-to-make-.patch
>
>
> Current slf4j import in wink bundles was binded to1.6.1 because of maven-bundle-plugin genereate the manefest file based on maven dependency.  This in turn will force any wink user in OSGi environment upgrade their slf4j to 1.6.1.    
> This is not easy in some cases.   As you know,  many OSGi users(including geronimo) are using PAX-logging as log bridge to OSGi log service.  The slf4j export version in PAX-logging is 1.5.3.
> If wink could change the slf4j import to  a range with a lower starting version.   It would be more OSGi user friendly.   Following is an example with wink-common module.  Please review it.
> If you agree, I will open a JIRA and attach a complete patch for it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WINK-330) Change slf4j api import to a range to make it more user friendly.

Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WINK-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shawn Jiang updated WINK-330:
-----------------------------

    Patch Info: [Patch Available]

> Change slf4j api import to a range to make it more user friendly.
> -----------------------------------------------------------------
>
>                 Key: WINK-330
>                 URL: https://issues.apache.org/jira/browse/WINK-330
>             Project: Wink
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 1.1.2
>            Reporter: Shawn Jiang
>         Attachments: 0001-WINK-330-Change-slf4j-api-import-to-a-range-to-make-.patch
>
>
> Current slf4j import in wink bundles was binded to1.6.1 because of maven-bundle-plugin genereate the manefest file based on maven dependency.  This in turn will force any wink user in OSGi environment upgrade their slf4j to 1.6.1.    
> This is not easy in some cases.   As you know,  many OSGi users(including geronimo) are using PAX-logging as log bridge to OSGi log service.  The slf4j export version in PAX-logging is 1.5.3.
> If wink could change the slf4j import to  a range with a lower starting version.   It would be more OSGi user friendly.   Following is an example with wink-common module.  Please review it.
> If you agree, I will open a JIRA and attach a complete patch for it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.