You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ap...@apache.org on 2018/11/08 18:22:56 UTC
[7/8] hbase git commit: HBASE-20604 ProtobufLogReader#readNext can
incorrectly loop to the same position in the stream until the the WAL is
rolled
HBASE-20604 ProtobufLogReader#readNext can incorrectly loop to the same position in the stream until the the WAL is rolled
Signed-off-by: Andrew Purtell <ap...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/3a13088a
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/3a13088a
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/3a13088a
Branch: refs/heads/branch-2.1
Commit: 3a13088a2e01d7de13a63cbdfc4058e4d02e667e
Parents: 0ec9f81
Author: Esteban Gutierrez <es...@apache.org>
Authored: Fri May 18 15:11:13 2018 -0500
Committer: Andrew Purtell <ap...@apache.org>
Committed: Thu Nov 8 10:22:21 2018 -0800
----------------------------------------------------------------------
.../regionserver/wal/ProtobufLogReader.java | 30 +++++++++++++++-----
1 file changed, 23 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/3a13088a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
index 83398bd..494cce5 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogReader.java
@@ -340,6 +340,7 @@ public class ProtobufLogReader extends ReaderBase {
}
WALKey.Builder builder = WALKey.newBuilder();
long size = 0;
+ boolean resetPosition = false;
try {
long available = -1;
try {
@@ -358,6 +359,7 @@ public class ProtobufLogReader extends ReaderBase {
ProtobufUtil.mergeFrom(builder, ByteStreams.limit(this.inputStream, size),
(int)size);
} catch (InvalidProtocolBufferException ipbe) {
+ resetPosition = true;
throw (EOFException) new EOFException("Invalid PB, EOF? Ignoring; originalPosition=" +
originalPosition + ", currentPosition=" + this.inputStream.getPos() +
", messageSize=" + size + ", currentAvailable=" + available).initCause(ipbe);
@@ -375,13 +377,15 @@ public class ProtobufLogReader extends ReaderBase {
LOG.trace("WALKey has no KVs that follow it; trying the next one. current offset=" +
this.inputStream.getPos());
}
- continue;
+ seekOnFs(originalPosition);
+ return false;
}
int expectedCells = walKey.getFollowingKvCount();
long posBefore = this.inputStream.getPos();
try {
int actualCells = entry.getEdit().readFromCells(cellDecoder, expectedCells);
if (expectedCells != actualCells) {
+ resetPosition = true;
throw new EOFException("Only read " + actualCells); // other info added in catch
}
} catch (Exception ex) {
@@ -409,16 +413,28 @@ public class ProtobufLogReader extends ReaderBase {
// If originalPosition is < 0, it is rubbish and we cannot use it (probably local fs)
if (originalPosition < 0) {
if (LOG.isTraceEnabled()) {
- LOG.trace("Encountered a malformed edit, but can't seek back to last good position because originalPosition is negative. last offset=" + this.inputStream.getPos(), eof);
+ LOG.trace("Encountered a malformed edit, but can't seek back to last good position "
+ + "because originalPosition is negative. last offset="
+ + this.inputStream.getPos(), eof);
}
throw eof;
}
- // Else restore our position to original location in hope that next time through we will
- // read successfully.
- if (LOG.isTraceEnabled()) {
- LOG.trace("Encountered a malformed edit, seeking back to last good position in file, from "+ inputStream.getPos()+" to " + originalPosition, eof);
+ // If stuck at the same place and we got and exception, lets go back at the beginning.
+ if (inputStream.getPos() == originalPosition && resetPosition) {
+ if (LOG.isTraceEnabled()) {
+ LOG.trace("Encountered a malformed edit, seeking to the beginning of the WAL since "
+ + "current position and original position match at " + originalPosition);
+ }
+ seekOnFs(0);
+ } else {
+ // Else restore our position to original location in hope that next time through we will
+ // read successfully.
+ if (LOG.isTraceEnabled()) {
+ LOG.trace("Encountered a malformed edit, seeking back to last good position in file, "
+ + "from " + inputStream.getPos()+" to " + originalPosition, eof);
+ }
+ seekOnFs(originalPosition);
}
- seekOnFs(originalPosition);
return false;
}
return true;