[GitHub] [yunikorn-k8shim] steinsgateted commented on pull request #422: [YUNIKORN-186] clean up events in k8shim

[GitBox <gi...@apache.org>]

steinsgateted commented on PR #422:
URL: https://github.com/apache/yunikorn-k8shim/pull/422#issuecomment-1138821805

   @craigcondit Thanks for your review.
   I would like some clarifications.
   Need to open another jira to put all the `zap.String("", var.String())` to `zap.Stringer("", var)` ?
   then I found 
   ```
   func beforeHook(event TaskEventType) string {
       return fmt.Sprintf("before_%s", event.String())
   }
   ```
   .String() can be removed :
   ```
   func beforeHook(event TaskEventType) string {
       return fmt.Sprintf("before_%s", event)
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org