You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2017/08/16 09:32:23 UTC
Review Request 61683: LENS-1439: Having clause getting skipped if
query goes to a segmentation containing single segment
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61683/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1439
https://issues.apache.org/jira/browse/LENS-1439
Repository: lens
Description
-------
The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 494b08e3b04bcdfea3de449f3740589cc481ba38
Diff: https://reviews.apache.org/r/61683/diff/1/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 61683: LENS-1439: Having clause getting skipped if
query goes to a segmentation containing single segment
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61683/#review183913
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Aug. 21, 2017, 8:23 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61683/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2017, 8:23 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1439
> https://issues.apache.org/jira/browse/LENS-1439
>
>
> Repository: lens
>
>
> Description
> -------
>
> The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 494b08e3b04bcdfea3de449f3740589cc481ba38
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java 7e1714bc301a748bf2c49dc9a707c1072c36f66b
> lens-cube/src/test/resources/schema/cubes/derived/union_join_ctx_der1.xml c23a029b80ab4342e130d4778eb84559c6806b7e
>
>
> Diff: https://reviews.apache.org/r/61683/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 61683: LENS-1439: Having clause getting skipped if
query goes to a segmentation containing single segment
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61683/
-----------------------------------------------------------
(Updated Aug. 21, 2017, 1:53 p.m.)
Review request for lens.
Bugs: LENS-1439
https://issues.apache.org/jira/browse/LENS-1439
Repository: lens
Description
-------
The condition of {{setHaving(null)}} is wrong in singleCandidatehqlcontext
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java 494b08e3b04bcdfea3de449f3740589cc481ba38
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java 7e1714bc301a748bf2c49dc9a707c1072c36f66b
lens-cube/src/test/resources/schema/cubes/derived/union_join_ctx_der1.xml c23a029b80ab4342e130d4778eb84559c6806b7e
Diff: https://reviews.apache.org/r/61683/diff/2/
Changes: https://reviews.apache.org/r/61683/diff/1-2/
Testing
-------
Thanks,
Rajat Khandelwal