You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/03/10 02:58:04 UTC

[kudu-CR] rpc: make generated Proxies subclass Proxy

Hello Mike Percy, Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2511

to review the following change.

Change subject: rpc: make generated Proxies subclass Proxy
......................................................................

rpc: make generated Proxies subclass Proxy

Rather than composition, inheritance actually makes sense, so that we don't
have to generate pass-through methods for everything we want to expose in the
Proxy.

Change-Id: If910b91b1ffcb48641d631ede728b6adbaecf9a9
---
M src/kudu/rpc/protoc-gen-krpc.cc
1 file changed, 4 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/2511/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2511
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If910b91b1ffcb48641d631ede728b6adbaecf9a9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>