[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2582: Allow overriding of do_get & export useful macro

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2582:
URL: https://github.com/apache/arrow-rs/pull/2582#discussion_r955252190


##########
arrow-flight/src/sql/server.rs:
##########
@@ -61,6 +61,18 @@ pub trait FlightSqlService:
         ))
     }
 
+    /// Implementors may override to handle additional calls to do_get()
+    async fn custom_do_get(

Review Comment:
   Perhaps do_get_fallback might be a better name



##########
arrow-flight/src/sql/mod.rs:
##########
@@ -69,6 +69,7 @@ pub trait ProstMessageExt: prost::Message + Default {
     fn as_any(&self) -> prost_types::Any;
 }
 
+#[macro_export]

Review Comment:
   NGL exporting macros makes me very uncomfortable, especially for something that appears to be an extension trait... They tend to change and get reworked frequently...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org