You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Dian Fu <di...@gmail.com> on 2015/09/17 12:46:55 UTC
Review Request 38458: Sqoop2: Port the ApplicationClassLoader in
Hadoop into Sqoop
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38458/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2578
https://issues.apache.org/jira/browse/SQOOP-2578
Repository: sqoop-sqoop2
Description
-------
This aim of this JIRA is to port the ApplicationClassLoader in Hadoop into Sqoop. One of the reason why we don't directly depend on the ApplicationClassLoader implementation in Hadoop is the implementation in Hadoop is annotated as unstable. As the code isn't complicated, I'd like to just port it into Sqoop.
Diffs
-----
common/pom.xml 748fa7a
common/src/main/java/org/apache/sqoop/utils/ApplicationClassLoader.java PRE-CREATION
common/src/test/java/org/apache/sqoop/utils/TestApplicationClassLoader.java PRE-CREATION
Diff: https://reviews.apache.org/r/38458/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 38458: Sqoop2: Port the ApplicationClassLoader in
Hadoop into Sqoop
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38458/#review100818
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Sept. 25, 2015, 1:36 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38458/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 1:36 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2578
> https://issues.apache.org/jira/browse/SQOOP-2578
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> This aim of this JIRA is to port the ApplicationClassLoader in Hadoop into Sqoop. One of the reason why we don't directly depend on the ApplicationClassLoader implementation in Hadoop is the implementation in Hadoop is annotated as unstable. As the code isn't complicated, I'd like to just port it into Sqoop.
>
>
> Diffs
> -----
>
> common/pom.xml 748fa7a
> common/src/main/java/org/apache/sqoop/utils/ConnectorClassLoader.java PRE-CREATION
> common/src/main/resources/org.apache.sqoop.connector-classloader.properties PRE-CREATION
> common/src/test/java/org/apache/sqoop/utils/TestConnectorClassLoader.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38458/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 38458: Sqoop2: Port the ApplicationClassLoader in
Hadoop into Sqoop
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38458/
-----------------------------------------------------------
(Updated Sept. 25, 2015, 1:36 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2578
https://issues.apache.org/jira/browse/SQOOP-2578
Repository: sqoop-sqoop2
Description
-------
This aim of this JIRA is to port the ApplicationClassLoader in Hadoop into Sqoop. One of the reason why we don't directly depend on the ApplicationClassLoader implementation in Hadoop is the implementation in Hadoop is annotated as unstable. As the code isn't complicated, I'd like to just port it into Sqoop.
Diffs (updated)
-----
common/pom.xml 748fa7a
common/src/main/java/org/apache/sqoop/utils/ConnectorClassLoader.java PRE-CREATION
common/src/main/resources/org.apache.sqoop.connector-classloader.properties PRE-CREATION
common/src/test/java/org/apache/sqoop/utils/TestConnectorClassLoader.java PRE-CREATION
Diff: https://reviews.apache.org/r/38458/diff/
Testing
-------
Thanks,
Dian Fu
Re: Review Request 38458: Sqoop2: Port the ApplicationClassLoader in
Hadoop into Sqoop
Posted by Dian Fu <di...@gmail.com>.
> On Sept. 22, 2015, 2:27 a.m., Jarek Cecho wrote:
> > I have just one nit, otherwise looks good to me.
Thanks Jarcec for the review. Make sense. Updated the patch.
- Dian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38458/#review99908
-----------------------------------------------------------
On Sept. 25, 2015, 1:36 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38458/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2015, 1:36 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2578
> https://issues.apache.org/jira/browse/SQOOP-2578
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> This aim of this JIRA is to port the ApplicationClassLoader in Hadoop into Sqoop. One of the reason why we don't directly depend on the ApplicationClassLoader implementation in Hadoop is the implementation in Hadoop is annotated as unstable. As the code isn't complicated, I'd like to just port it into Sqoop.
>
>
> Diffs
> -----
>
> common/pom.xml 748fa7a
> common/src/main/java/org/apache/sqoop/utils/ConnectorClassLoader.java PRE-CREATION
> common/src/main/resources/org.apache.sqoop.connector-classloader.properties PRE-CREATION
> common/src/test/java/org/apache/sqoop/utils/TestConnectorClassLoader.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38458/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 38458: Sqoop2: Port the ApplicationClassLoader in
Hadoop into Sqoop
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38458/#review99908
-----------------------------------------------------------
I have just one nit, otherwise looks good to me.
common/src/main/java/org/apache/sqoop/utils/ApplicationClassLoader.java (line 38)
<https://reviews.apache.org/r/38458/#comment156916>
Let's call it "ConnectorClassLoader" since we're gonna use it for connector code?
Jarcec
- Jarek Cecho
On Sept. 18, 2015, 9:02 a.m., Dian Fu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38458/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 9:02 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2578
> https://issues.apache.org/jira/browse/SQOOP-2578
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> This aim of this JIRA is to port the ApplicationClassLoader in Hadoop into Sqoop. One of the reason why we don't directly depend on the ApplicationClassLoader implementation in Hadoop is the implementation in Hadoop is annotated as unstable. As the code isn't complicated, I'd like to just port it into Sqoop.
>
>
> Diffs
> -----
>
> common/pom.xml 748fa7a
> common/src/main/java/org/apache/sqoop/utils/ApplicationClassLoader.java PRE-CREATION
> common/src/main/resources/org.apache.sqoop.application-classloader.properties PRE-CREATION
> common/src/test/java/org/apache/sqoop/utils/TestApplicationClassLoader.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38458/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dian Fu
>
>
Re: Review Request 38458: Sqoop2: Port the ApplicationClassLoader in
Hadoop into Sqoop
Posted by Dian Fu <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38458/
-----------------------------------------------------------
(Updated Sept. 18, 2015, 9:02 a.m.)
Review request for Sqoop.
Bugs: SQOOP-2578
https://issues.apache.org/jira/browse/SQOOP-2578
Repository: sqoop-sqoop2
Description
-------
This aim of this JIRA is to port the ApplicationClassLoader in Hadoop into Sqoop. One of the reason why we don't directly depend on the ApplicationClassLoader implementation in Hadoop is the implementation in Hadoop is annotated as unstable. As the code isn't complicated, I'd like to just port it into Sqoop.
Diffs (updated)
-----
common/pom.xml 748fa7a
common/src/main/java/org/apache/sqoop/utils/ApplicationClassLoader.java PRE-CREATION
common/src/main/resources/org.apache.sqoop.application-classloader.properties PRE-CREATION
common/src/test/java/org/apache/sqoop/utils/TestApplicationClassLoader.java PRE-CREATION
Diff: https://reviews.apache.org/r/38458/diff/
Testing
-------
Thanks,
Dian Fu