You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Andy Schwartz (JIRA)" <de...@myfaces.apache.org> on 2011/08/17 22:37:27 UTC
[jira] [Created] (TRINIDAD-2130) Skinning: support separate style
sheets for secure + non-secure pages
Skinning: support separate style sheets for secure + non-secure pages
---------------------------------------------------------------------
Key: TRINIDAD-2130
URL: https://issues.apache.org/jira/browse/TRINIDAD-2130
Project: MyFaces Trinidad
Issue Type: Improvement
Components: Skinning
Reporter: Andy Schwartz
Priority: Minor
I have an ExternalContext wrapper that modifies urls that are passed to ExternalContext.encodeResourceURL(). This includes urls for images referenced by Trinidad skin definitions.
One possible modification involves converting relative URLs to absolute URLs (eg. prepending a CDN prefix), including the protocol/host/port.
A problem with this is that we share a single generated style sheet across http and https pages. This means that if I generate absolute uris with the "http:" protocol, these uris will be written into a generated .css file that would be shared by secure/https pages, in which case the browser may warn about mixed secure/non-secure content.
I would like to avoid this issue by enhancing Trinidad skinning to support generation of separate style sheets for secure and non-secure pages. That way, my ExternalContext wrapper could produce absolute uris with the appropriate protocol for the current request and avoid mixing secure/non-secure content.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2130) Skinning: support separate style
sheets for secure + non-secure pages
Posted by "Andy Schwartz (Commented) (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173779#comment-13173779 ]
Andy Schwartz commented on TRINIDAD-2130:
-----------------------------------------
Woops, sorry about that! I have uploaded a new version of the patch which grants license to ASF.
> Skinning: support separate style sheets for secure + non-secure pages
> ---------------------------------------------------------------------
>
> Key: TRINIDAD-2130
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2130
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Skinning
> Reporter: Andy Schwartz
> Assignee: Andy Schwartz
> Priority: Minor
> Fix For: 2.0.2-core
>
> Attachments: trinidad-2130.patch
>
>
> I have an ExternalContext wrapper that modifies urls that are passed to ExternalContext.encodeResourceURL(). This includes urls for images referenced by Trinidad skin definitions.
> One possible modification involves converting relative URLs to absolute URLs (eg. prepending a CDN prefix), including the protocol/host/port.
> A problem with this is that we share a single generated style sheet across http and https pages. This means that if I generate absolute uris with the "http:" protocol, these uris will be written into a generated .css file that would be shared by secure/https pages, in which case the browser may warn about mixed secure/non-secure content.
> I would like to avoid this issue by enhancing Trinidad skinning to support generation of separate style sheets for secure and non-secure pages. That way, my ExternalContext wrapper could produce absolute uris with the appropriate protocol for the current request and avoid mixing secure/non-secure content.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TRINIDAD-2130) Skinning: support separate style
sheets for secure + non-secure pages
Posted by "Andy Schwartz (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andy Schwartz updated TRINIDAD-2130:
------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.2-core
Status: Resolved (was: Patch Available)
We now generate separate style sheets for secure/non-secure pages.
> Skinning: support separate style sheets for secure + non-secure pages
> ---------------------------------------------------------------------
>
> Key: TRINIDAD-2130
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2130
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Skinning
> Reporter: Andy Schwartz
> Priority: Minor
> Fix For: 2.0.2-core
>
> Attachments: trinidad-2130.patch
>
>
> I have an ExternalContext wrapper that modifies urls that are passed to ExternalContext.encodeResourceURL(). This includes urls for images referenced by Trinidad skin definitions.
> One possible modification involves converting relative URLs to absolute URLs (eg. prepending a CDN prefix), including the protocol/host/port.
> A problem with this is that we share a single generated style sheet across http and https pages. This means that if I generate absolute uris with the "http:" protocol, these uris will be written into a generated .css file that would be shared by secure/https pages, in which case the browser may warn about mixed secure/non-secure content.
> I would like to avoid this issue by enhancing Trinidad skinning to support generation of separate style sheets for secure and non-secure pages. That way, my ExternalContext wrapper could produce absolute uris with the appropriate protocol for the current request and avoid mixing secure/non-secure content.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TRINIDAD-2130) Skinning: support separate style
sheets for secure + non-secure pages
Posted by "Andy Schwartz (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andy Schwartz updated TRINIDAD-2130:
------------------------------------
Status: Patch Available (was: Open)
> Skinning: support separate style sheets for secure + non-secure pages
> ---------------------------------------------------------------------
>
> Key: TRINIDAD-2130
> URL: https://issues.apache.org/jira/browse/TRINIDAD-2130
> Project: MyFaces Trinidad
> Issue Type: Improvement
> Components: Skinning
> Reporter: Andy Schwartz
> Priority: Minor
> Attachments: trinidad-2130.patch
>
>
> I have an ExternalContext wrapper that modifies urls that are passed to ExternalContext.encodeResourceURL(). This includes urls for images referenced by Trinidad skin definitions.
> One possible modification involves converting relative URLs to absolute URLs (eg. prepending a CDN prefix), including the protocol/host/port.
> A problem with this is that we share a single generated style sheet across http and https pages. This means that if I generate absolute uris with the "http:" protocol, these uris will be written into a generated .css file that would be shared by secure/https pages, in which case the browser may warn about mixed secure/non-secure content.
> I would like to avoid this issue by enhancing Trinidad skinning to support generation of separate style sheets for secure and non-secure pages. That way, my ExternalContext wrapper could produce absolute uris with the appropriate protocol for the current request and avoid mixing secure/non-secure content.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira