You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by JaneAarthy <gi...@git.apache.org> on 2015/06/26 08:42:54 UTC

[GitHub] stratos pull request: Add database/

GitHub user JaneAarthy opened a pull request:

    https://github.com/apache/stratos/pull/378

    Add database/

    Adding ER model and database scripts for StratosManager

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JaneAarthy/stratos master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/stratos/pull/378.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #378
    
----
commit 0a46d29fbb0e3ed23a099c262e680a76ef4f3216
Author: Jane Aarthy <ja...@wso2.com>
Date:   2015-06-26T04:49:47Z

    Add database/

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Add database/

Posted by JaneAarthy <gi...@git.apache.org>.
Github user JaneAarthy commented on the pull request:

    https://github.com/apache/stratos/pull/378#issuecomment-125511119
  
    moving the changes to the database-model branch


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Add database/

Posted by sajhak <gi...@git.apache.org>.
Github user sajhak commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/378#discussion_r36175848
  
    --- Diff: components/org.apache.stratos.manager/src/main/database/SM.sql ---
    @@ -0,0 +1,79 @@
    +SET @OLD_UNIQUE_CHECKS=@@UNIQUE_CHECKS, UNIQUE_CHECKS=0;
    +SET @OLD_FOREIGN_KEY_CHECKS=@@FOREIGN_KEY_CHECKS, FOREIGN_KEY_CHECKS=0;
    +SET @OLD_SQL_MODE=@@SQL_MODE, SQL_MODE='TRADITIONAL,ALLOW_INVALID_DATES';
    +
    +CREATE SCHEMA IF NOT EXISTS `StratosManager` DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci ;
    +USE `StratosManager` ;
    +
    +-- -----------------------------------------------------
    +-- Table `StratosManager`.`Cluster`
    +-- -----------------------------------------------------
    +CREATE TABLE IF NOT EXISTS `StratosManager`.`Cluster` (
    +  `clusterId` VARCHAR(255) NULL,
    --- End diff --
    
    @JaneAarthy , why this clusterId, which is also declared as the Primary key,  is defined as a 'NULL' ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Add database/

Posted by imesh <gi...@git.apache.org>.
Github user imesh commented on the pull request:

    https://github.com/apache/stratos/pull/378#issuecomment-116036223
  
    Thanks @JaneAarthy for the pull request. We might need to wait until we release Stratos 4.1.0 to merge this pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Add database/

Posted by JaneAarthy <gi...@git.apache.org>.
Github user JaneAarthy closed the pull request at:

    https://github.com/apache/stratos/pull/378


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Add database/

Posted by Vishanth <gi...@git.apache.org>.
Github user Vishanth commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/378#discussion_r35620930
  
    --- Diff: components/org.apache.stratos.manager/src/main/java/org/apache/stratos/manager/persistence/PersistenceManager.java ---
    @@ -0,0 +1,112 @@
    +package org.apache.stratos.manager.persistence;
    +
    +import org.apache.commons.logging.Log;
    +import org.apache.commons.logging.LogFactory;
    +import org.apache.stratos.manager.exception.ApplicationSignUpException;
    +import org.apache.stratos.manager.model.ApplicationSignUpEntity;
    +import org.apache.stratos.manager.model.ApplicationSignUpEntityPK;
    +
    +import javax.persistence.EntityManager;
    +import javax.persistence.EntityManagerFactory;
    +
    +import javax.persistence.Persistence;
    +import java.util.ArrayList;
    +import java.util.List;
    +
    +/**
    + * Created by aarthy on 7/6/15.
    + */
    --- End diff --
    
    @JaneAarthy we don't put created by comment. We only put the Apache License header for the classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] stratos pull request: Add database/

Posted by imesh <gi...@git.apache.org>.
Github user imesh commented on the pull request:

    https://github.com/apache/stratos/pull/378#issuecomment-125480196
  
    @JaneAarthy Shall we move this feature implementation to database-model branch? If so may be you can close this pull request and send a new one.
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---