You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/02/18 15:25:22 UTC

[GitHub] [cloudstack] weizhouapache commented on pull request #5970: Improve default network offering setting for egress policy

weizhouapache commented on pull request #5970:
URL: https://github.com/apache/cloudstack/pull/5970#issuecomment-1044698771


   code lgtm
   
   @Pearl1594 
   I have two suggestions
   
   (1) display "Allow/Deny" instead of "true/false" on UI. see below
   ![image](https://user-images.githubusercontent.com/57355700/154711339-75f67ca4-d159-4f96-9506-0dd7cf7068a7.png)
   
   
   (2) display the message in egress tab. for example
   
   ![image](https://user-images.githubusercontent.com/57355700/154711410-12c7a7b0-9247-438f-92fd-c67f3e7639ce.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org