You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Brian Cho (JIRA)" <ji...@apache.org> on 2015/08/03 03:00:06 UTC

[jira] [Commented] (REEF-546) Remove APIs deprecated since 0.11 from Tang

    [ https://issues.apache.org/jira/browse/REEF-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14651316#comment-14651316 ] 

Brian Cho commented on REEF-546:
--------------------------------

Adding {{EnvironmentUtils.java}} in this JIRA, as the deprecated methods are Tang-related.

{noformat}
--
lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java:108:  @Deprecated
lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java-109-  public static <P extends Param> ConfigurationModule addAll(
lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java-110-      ConfigurationModule config, final P param, final Iterable<String> values) {
--
lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java:124:  @Deprecated
lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java-125-  public static ConfigurationModule addClasspath(
lang/java/reef-common/src/main/java/org/apache/reef/util/EnvironmentUtils.java-126-      final ConfigurationModule config, final OptionalParameter<String> param) {
--
{noformat}

> Remove APIs deprecated since 0.11 from Tang
> -------------------------------------------
>
>                 Key: REEF-546
>                 URL: https://issues.apache.org/jira/browse/REEF-546
>             Project: REEF
>          Issue Type: Sub-task
>          Components: Tang
>            Reporter: Brian Cho
>             Fix For: 0.12
>
>
> Tang seems to be the worst offender in continuing to use "deprecated" methods and classes. We need to figure out which ones are truly unneeded, and which ones we should upgrade to non-deprecated status.
> A grepped list of deprecated parts:
> {noformat}
> --
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Configuration.java:159:  @Deprecated
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Configuration.java-160-  Iterable<Entry<NamedParameterNode<Set<?>>, Object>> getBoundSets();
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/Configuration.java-161-
> --
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java:45:@Deprecated
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-46-public class ConfigurationFile {
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-47-
> --
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java:54:  @Deprecated
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-55-  public static void writeConfigurationFile(
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-56-      final Configuration conf, final File confFile) throws IOException {
> --
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java:65:  @Deprecated
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-66-  public static void addConfiguration(final ConfigurationBuilder conf,
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-67-                                      final File tmpConfFile) throws IOException, BindException {
> --
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java:84:  @Deprecated
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-85-  public static void addConfiguration(final ConfigurationBuilder conf,
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-86-                                      final String contents) throws BindException {
> --
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java:184:  @Deprecated
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-185-  public static String toConfigurationString(final Configuration c) {
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-186-    StringBuilder sb = new StringBuilder();
> --
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java:197:  @Deprecated
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-198-  static List<String> toConfigurationStringList(final Configuration c) {
> lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationFile.java-199-    ConfigurationImpl conf = (ConfigurationImpl) c;
> --
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)