You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@celeborn.apache.org by zh...@apache.org on 2023/09/08 12:12:25 UTC
[incubator-celeborn] branch branch-0.3 updated: [CELEBORN-958] Log DNS resolution result
This is an automated email from the ASF dual-hosted git repository.
zhouky pushed a commit to branch branch-0.3
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git
The following commit(s) were added to refs/heads/branch-0.3 by this push:
new 30e2470ea [CELEBORN-958] Log DNS resolution result
30e2470ea is described below
commit 30e2470ea2a88e95a1ce12c546dad0f00f005e05
Author: sychen <sy...@ctrip.com>
AuthorDate: Fri Sep 8 20:12:04 2023 +0800
[CELEBORN-958] Log DNS resolution result
### What changes were proposed in this pull request?
In some scenarios, DNS resolution may fail. We can record the DNS resolution results like Spark.
https://github.com/apache/spark/blob/fd424caf6c46e7030ac2deb2afbe3f4a5fc1095c/common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java#L185-L192
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
Closes #1891 from cxzl25/CELEBORN-958.
Authored-by: sychen <sy...@ctrip.com>
Signed-off-by: zky.zhoukeyong <zk...@alibaba-inc.com>
(cherry picked from commit fe2ce00176153410c7065a2234ef92e159f5a0f5)
Signed-off-by: zky.zhoukeyong <zk...@alibaba-inc.com>
---
.../celeborn/common/network/client/TransportClientFactory.java | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/common/src/main/java/org/apache/celeborn/common/network/client/TransportClientFactory.java b/common/src/main/java/org/apache/celeborn/common/network/client/TransportClientFactory.java
index ad8de7b21..1f26240e6 100644
--- a/common/src/main/java/org/apache/celeborn/common/network/client/TransportClientFactory.java
+++ b/common/src/main/java/org/apache/celeborn/common/network/client/TransportClientFactory.java
@@ -163,10 +163,13 @@ public class TransportClientFactory implements Closeable {
final InetSocketAddress resolvedAddress = new InetSocketAddress(remoteHost, remotePort);
final long hostResolveTimeMs =
TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - preResolveHost);
+ final String resolveMsg = resolvedAddress.isUnresolved() ? "failed" : "succeed";
if (hostResolveTimeMs > 2000) {
- logger.warn("DNS resolution for {} took {} ms", resolvedAddress, hostResolveTimeMs);
+ logger.warn(
+ "DNS resolution {} for {} took {} ms", resolveMsg, resolvedAddress, hostResolveTimeMs);
} else {
- logger.trace("DNS resolution for {} took {} ms", resolvedAddress, hostResolveTimeMs);
+ logger.trace(
+ "DNS resolution {} for {} took {} ms", resolveMsg, resolvedAddress, hostResolveTimeMs);
}
synchronized (clientPool.locks[clientIndex]) {