You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2016/02/11 16:31:56 UTC
[GitHub] cordova-plugin-geolocation pull request: CB-10594 geolocation.spec...
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/69
CB-10594 geolocation.spec.10 crashes Windows Phone 8.1
[Jira issue](https://issues.apache.org/jira/browse/CB-10594)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-geolocation CB-10594
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-geolocation/pull/69.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #69
----
commit 15ff13bb7828334cd50850cc49949046a93a9a19
Author: daserge <v-...@microsoft.com>
Date: 2016-02-11T15:25:59Z
CB-10594 geolocation.spec.10 crashes Windows Phone 8.1
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10594 geolocation.spec...
Posted by daserge <gi...@git.apache.org>.
Github user daserge closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/69
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10594 geolocation.spec...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/69#issuecomment-183442760
@sarangan12, listeners are removed and then subsribed again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10594 geolocation.spec...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/69#discussion_r52679939
--- Diff: tests/tests.js ---
@@ -174,8 +174,12 @@ exports.defineAutoTests = function () {
describe('error callback', function () {
var errorWatch = null;
- afterEach(function () {
- navigator.geolocation.clearWatch(errorWatch);
+ afterEach(function (done) {
+ // Workaround to avoid the crash "0x80004004 - JavaScript runtime error: Operation aborted" on Windows
+ setTimeout(function () {
+ navigator.geolocation.clearWatch(errorWatch);
+ done();
+ }, 100);
--- End diff --
This looks like magic. Why does 100ms fix the issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10594 geolocation.spec...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/69#issuecomment-183559781
@daserge this change will change an *existing* listener, which is not expected behaviour. It is expected that when `addWatch` is called a second time, a new watch is created and the previous watch is not modified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10594 geolocation.spec...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/69#issuecomment-183411853
@dblotsky, @sarangan12, I've updated the PR, please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10594 geolocation.spec...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/69#issuecomment-183559873
Please review #70. It looks like it specifically fixes the behaviour to match what's expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: CB-10594 geolocation.spec...
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/69#issuecomment-183439690
@daserge I am not sure if removing the event listeners is a good idea. From the user perspective, there is no reason for him to have only one event listener. All of this boils down to one issue, reusing the 'loc' variable. With the restriction that you cannot modify the properties when there are event listeners on it, I do not see a good point in reusing it (in ensurelocator function) I have created another PR to address that issue: https://github.com/apache/cordova-plugin-geolocation/pull/70
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org