You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by co...@apache.org on 2025/09/12 14:52:54 UTC
(datafusion-comet) branch main updated: chore: Output `BaseAggregateExec` accurate unsupported names (#2383)
This is an automated email from the ASF dual-hosted git repository.
comphead pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git
The following commit(s) were added to refs/heads/main by this push:
new d9c2b3a3b chore: Output `BaseAggregateExec` accurate unsupported names (#2383)
d9c2b3a3b is described below
commit d9c2b3a3b7273cffb09685c5d33a257627e84cf3
Author: Oleks V <co...@users.noreply.github.com>
AuthorDate: Fri Sep 12 07:52:50 2025 -0700
chore: Output `BaseAggregateExec` accurate unsupported names (#2383)
* chore: Output `BaseAggregateExec` accurate unsupported names
---
.../main/scala/org/apache/comet/serde/QueryPlanSerde.scala | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala b/spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
index 5dcccdae3..1742912d8 100644
--- a/spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
+++ b/spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
@@ -1305,12 +1305,20 @@ object QueryPlanSerde extends Logging with CometExprShim {
return None
}
- val groupingExprs = groupingExpressions.map(exprToProto(_, child.output))
- if (groupingExprs.exists(_.isEmpty)) {
- withInfo(op, "Not all grouping expressions are supported")
+ val groupingExprsWithInput =
+ groupingExpressions.map(expr => expr.name -> exprToProto(expr, child.output))
+
+ val emptyExprs = groupingExprsWithInput.collect {
+ case (expr, proto) if proto.isEmpty => expr
+ }
+
+ if (emptyExprs.nonEmpty) {
+ withInfo(op, s"Unsupported group expressions: ${emptyExprs.mkString(", ")}")
return None
}
+ val groupingExprs = groupingExprsWithInput.map(_._2)
+
// In some of the cases, the aggregateExpressions could be empty.
// For example, if the aggregate functions only have group by or if the aggregate
// functions only have distinct aggregate functions:
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org