[GitHub] [ozone] errose28 commented on a diff in pull request #3841: HDDS-7320. Enable Container SchemaV3 by default.

[GitBox <gi...@apache.org>]

errose28 commented on code in PR #3841:
URL: https://github.com/apache/ozone/pull/3841#discussion_r998584227


##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/upgrade/TestDatanodeUpgradeToScmHA.java:
##########
@@ -103,6 +104,8 @@ public TestDatanodeUpgradeToScmHA(boolean scmHAAlreadyEnabled) {
     this.scmHAAlreadyEnabled = scmHAAlreadyEnabled;
     conf = new OzoneConfiguration();
     conf.setBoolean(ScmConfigKeys.OZONE_SCM_HA_ENABLE_KEY, scmHAAlreadyEnabled);
+    // DATANODE_SCHEMA_V3 has higher feature version than SCM_HA
+    conf.setBoolean(DatanodeConfiguration.CONTAINER_SCHEMA_V3_ENABLED, false);

Review Comment:
   What was the error seen here that led to this line being added? This test should not need to be updated every time we add a new layout feature.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org