You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Bertrand Delacretaz (JIRA)" <ji...@apache.org> on 2007/10/15 16:46:50 UTC
[jira] Created: (SLING-50) microsling: complete the
SlingRequestContext information
microsling: complete the SlingRequestContext information
--------------------------------------------------------
Key: SLING-50
URL: https://issues.apache.org/jira/browse/SLING-50
Project: Sling
Issue Type: Improvement
Components: microsling
Reporter: Bertrand Delacretaz
Comparing microsling with the "full" Sling, the SlingRequestContext needs the following additional information:
1) ParsedRequestPath: extension, selectors, suffix, etc.
2) SlingRequestParameters: a wrapper for the HttpServletRequest parameters, that gives transparent access to parameters coming from multipart forms (at least in the full Sling, but the interface must be the same).
3) MimeTypeResolver: factor out the current SlingRequestContext.getMimeType() method
The SlingRequestContext should as much as possible remain a container only, and delegate parsing and other tasks to separate classes
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-50) microsling: complete the
SlingRequestContext information
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535175 ]
Bertrand Delacretaz commented on SLING-50:
------------------------------------------
Ok for dropping MimeTypeResolver
> microsling: complete the SlingRequestContext information
> --------------------------------------------------------
>
> Key: SLING-50
> URL: https://issues.apache.org/jira/browse/SLING-50
> Project: Sling
> Issue Type: Improvement
> Components: microsling
> Reporter: Bertrand Delacretaz
>
> Comparing microsling with the "full" Sling, the SlingRequestContext needs the following additional information:
> 1) ParsedRequestPath: extension, selectors, suffix, etc.
> 2) SlingRequestParameters: a wrapper for the HttpServletRequest parameters, that gives transparent access to parameters coming from multipart forms (at least in the full Sling, but the interface must be the same).
> 3) MimeTypeResolver: factor out the current SlingRequestContext.getMimeType() method
> The SlingRequestContext should as much as possible remain a container only, and delegate parsing and other tasks to separate classes
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-50) microsling: complete the
SlingRequestContext information
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Delacretaz resolved SLING-50.
--------------------------------------
Resolution: Fixed
I think this issue is solved by the various changes done since it was created, please reopen if I'm wrong.
> microsling: complete the SlingRequestContext information
> --------------------------------------------------------
>
> Key: SLING-50
> URL: https://issues.apache.org/jira/browse/SLING-50
> Project: Sling
> Issue Type: Improvement
> Components: microsling
> Reporter: Bertrand Delacretaz
>
> Comparing microsling with the "full" Sling, the SlingRequestContext needs the following additional information:
> 1) ParsedRequestPath: extension, selectors, suffix, etc.
> 2) SlingRequestParameters: a wrapper for the HttpServletRequest parameters, that gives transparent access to parameters coming from multipart forms (at least in the full Sling, but the interface must be the same).
> 3) MimeTypeResolver: factor out the current SlingRequestContext.getMimeType() method
> The SlingRequestContext should as much as possible remain a container only, and delegate parsing and other tasks to separate classes
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-50) microsling: complete the
SlingRequestContext information
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535166 ]
Felix Meschberger commented on SLING-50:
----------------------------------------
> MimeTypeResolver: factor out the current SlingRequestContext.getMimeType() method
I think we should actually just drop the getMimeType() method and not introduce a MimeTypeResolver in microsling because the API is available from the ServletContext (getMimeType) and this method should also be used by microsling and Sling servlets.
NB: In the real Sling, we might of course implement better MimeType resoultion through the HttpContext we use to register the Sling Servlet with the OSGi HttpService.
> microsling: complete the SlingRequestContext information
> --------------------------------------------------------
>
> Key: SLING-50
> URL: https://issues.apache.org/jira/browse/SLING-50
> Project: Sling
> Issue Type: Improvement
> Components: microsling
> Reporter: Bertrand Delacretaz
>
> Comparing microsling with the "full" Sling, the SlingRequestContext needs the following additional information:
> 1) ParsedRequestPath: extension, selectors, suffix, etc.
> 2) SlingRequestParameters: a wrapper for the HttpServletRequest parameters, that gives transparent access to parameters coming from multipart forms (at least in the full Sling, but the interface must be the same).
> 3) MimeTypeResolver: factor out the current SlingRequestContext.getMimeType() method
> The SlingRequestContext should as much as possible remain a container only, and delegate parsing and other tasks to separate classes
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.