You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/08/02 15:45:33 UTC

[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1094: feat: Support Build on M1 MacOS

acelyc111 commented on code in PR #1094:
URL: https://github.com/apache/incubator-pegasus/pull/1094#discussion_r935738679


##########
.licenserc.yaml:
##########
@@ -90,6 +90,7 @@ header:
     - 'thirdparty/fix_libevent_for_macos.patch'
     - 'thirdparty/fix_s2_for_aarch64.patch'
     - 'thirdparty/fix_thrift_for_cpp11.patch'
+    - 'thirdparty/fix_jemalloc_for_m1_on_macos.patch'

Review Comment:
   ```suggestion
       - 'thirdparty/fix_jemalloc_for_m1_on_macos.patch'
       - 'thirdparty/fix_libevent_for_macos.patch'
       - 'thirdparty/fix_s2_for_aarch64.patch'
       - 'thirdparty/fix_thrift_for_cpp11.patch'
   ```
   keep in lexicographic order



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org