You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/08/23 03:55:36 UTC
[GitHub] [incubator-doris] morningman commented on a change in pull request #6487: Submit Doris manager code
morningman commented on a change in pull request #6487:
URL: https://github.com/apache/incubator-doris/pull/6487#discussion_r693630177
##########
File path: manager/dm-server/pom.xml
##########
@@ -18,26 +18,21 @@
<java.version>1.8</java.version>
</properties>
<dependencies>
- <dependency>
- <groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-starter-web</artifactId>
- </dependency>
+<!-- <dependency>-->
Review comment:
Remove unused code
##########
File path: manager/general/src/main/java/org/apache/doris/stack/exception/UserFailedLoginTooManyException.java
##########
@@ -0,0 +1,27 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.stack.exception;
+
+public class UserFailedLoginTooManyException extends Exception {
+
+ public static final String MESSAGE = "登录失败次数过多，五分钟后重试";
Review comment:
English
##########
File path: manager/dm-server/src/main/resources/application.properties
##########
@@ -1,11 +1,11 @@
-server.port=9601
-
-spring.datasource.url = jdbc:mysql://localhost:3306/doris_manager?allowMultiQueries=true&useUnicode=true&characterEncoding=UTF-8&zeroDateTimeBehavior=convertToNull&useSSL=false&serverTimezone=GMT%2B8
-spring.datasource.username = root
-spring.datasource.password = password
-
-doris.manager.agent.install.dir = /usr/local/doris-manager
-doris.manager.agent.start-script = agent/bin/agent_start.sh
+#server.port=9601
+#
+#spring.datasource.url = jdbc:mysql://10.138.64.225:8306/test3?allowMultiQueries=true&useUnicode=true&characterEncoding=UTF-8&zeroDateTimeBehavior=convertToNull&useSSL=false&serverTimezone=GMT%2B8
Review comment:
remove ip
##########
File path: manager/dm-server/src/main/java/org/apache/doris/stack/component/AgentComponent.java
##########
@@ -0,0 +1,74 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.stack.component;
+
+import lombok.extern.slf4j.Slf4j;
Review comment:
import order, please refer to `http://doris.incubator.apache.org/master/zh-CN/developer-guide/java-format-code.html#import-order`
##########
File path: manager/build.sh
##########
@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
Review comment:
License header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org