You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Seth Green (JIRA)" <ji...@apache.org> on 2007/05/06 19:01:15 UTC
[jira] Created: (WICKET-540) ServletWebRequest.getContextPath()
ignores ContextPath as set by user (accesses HttpServletRequest directly)
ServletWebRequest.getContextPath() ignores ContextPath as set by user (accesses HttpServletRequest directly)
-------------------------------------------------------------------------------------------------------------
Key: WICKET-540
URL: https://issues.apache.org/jira/browse/WICKET-540
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.2.5
Reporter: Seth Green
Priority: Critical
I'm running Wicket behind a front-end proxy. To fix certain issues with this I have set the ContextPath value in my application settings (and/or in Web.xml), However, when using functions that attempt to get at the context path (e.g. continueToOriginalDestination()) the app does not respect my setting.
This is because in ServletWebRequest, getContextPath() directly accesses HttpServletRequest without checking the application settings.
I believe it should first check the application settings, and only if ContextPath is /not/ set, then access the HttpServletRequest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-540) ServletWebRequest.getContextPath()
ignores ContextPath as set by user (accesses HttpServletRequest directly)
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw resolved WICKET-540.
---------------------------------
Resolution: Fixed
Fix Version/s: 1.2.7
Hmmm, this was actually a pretty trivial fix. It'll be in 1.2.7.
> ServletWebRequest.getContextPath() ignores ContextPath as set by user (accesses HttpServletRequest directly)
> -------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-540
> URL: https://issues.apache.org/jira/browse/WICKET-540
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.5
> Reporter: Seth Green
> Assigned To: Alastair Maw
> Priority: Critical
> Fix For: 1.2.7
>
>
> I'm running Wicket behind a front-end proxy. To fix certain issues with this I have set the ContextPath value in my application settings (and/or in Web.xml), However, when using functions that attempt to get at the context path (e.g. continueToOriginalDestination()) the app does not respect my setting.
> This is because in ServletWebRequest, getContextPath() directly accesses HttpServletRequest without checking the application settings.
> I believe it should first check the application settings, and only if ContextPath is /not/ set, then access the HttpServletRequest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-540) ServletWebRequest.getContextPath()
ignores ContextPath as set by user (accesses HttpServletRequest directly)
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Quenot reassigned WICKET-540:
-------------------------------------------
Assignee: Jean-Baptiste Quenot
> ServletWebRequest.getContextPath() ignores ContextPath as set by user (accesses HttpServletRequest directly)
> -------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-540
> URL: https://issues.apache.org/jira/browse/WICKET-540
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.5
> Reporter: Seth Green
> Assigned To: Jean-Baptiste Quenot
> Priority: Critical
>
> I'm running Wicket behind a front-end proxy. To fix certain issues with this I have set the ContextPath value in my application settings (and/or in Web.xml), However, when using functions that attempt to get at the context path (e.g. continueToOriginalDestination()) the app does not respect my setting.
> This is because in ServletWebRequest, getContextPath() directly accesses HttpServletRequest without checking the application settings.
> I believe it should first check the application settings, and only if ContextPath is /not/ set, then access the HttpServletRequest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-540) ServletWebRequest.getContextPath()
ignores ContextPath as set by user (accesses HttpServletRequest directly)
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw reassigned WICKET-540:
-----------------------------------
Assignee: Alastair Maw
> ServletWebRequest.getContextPath() ignores ContextPath as set by user (accesses HttpServletRequest directly)
> -------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-540
> URL: https://issues.apache.org/jira/browse/WICKET-540
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.5
> Reporter: Seth Green
> Assigned To: Alastair Maw
> Priority: Critical
>
> I'm running Wicket behind a front-end proxy. To fix certain issues with this I have set the ContextPath value in my application settings (and/or in Web.xml), However, when using functions that attempt to get at the context path (e.g. continueToOriginalDestination()) the app does not respect my setting.
> This is because in ServletWebRequest, getContextPath() directly accesses HttpServletRequest without checking the application settings.
> I believe it should first check the application settings, and only if ContextPath is /not/ set, then access the HttpServletRequest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-540) ServletWebRequest.getContextPath()
ignores ContextPath as set by user (accesses HttpServletRequest directly)
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495437 ]
Alastair Maw commented on WICKET-540:
-------------------------------------
I'm afraid we're unlikely to fix this in the 1.2.x branch, due to limited time and pressure to get 1.3 final out. If you can provide a patch, I'll review and commit it, however.
The 1.3.x branch uses relative URLs, which overcome this issue (you don't need to set a contextpath setting at all).
> ServletWebRequest.getContextPath() ignores ContextPath as set by user (accesses HttpServletRequest directly)
> -------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-540
> URL: https://issues.apache.org/jira/browse/WICKET-540
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.5
> Reporter: Seth Green
> Priority: Critical
>
> I'm running Wicket behind a front-end proxy. To fix certain issues with this I have set the ContextPath value in my application settings (and/or in Web.xml), However, when using functions that attempt to get at the context path (e.g. continueToOriginalDestination()) the app does not respect my setting.
> This is because in ServletWebRequest, getContextPath() directly accesses HttpServletRequest without checking the application settings.
> I believe it should first check the application settings, and only if ContextPath is /not/ set, then access the HttpServletRequest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-540) ServletWebRequest.getContextPath()
ignores ContextPath as set by user (accesses HttpServletRequest directly)
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Quenot reassigned WICKET-540:
-------------------------------------------
Assignee: (was: Jean-Baptiste Quenot)
> ServletWebRequest.getContextPath() ignores ContextPath as set by user (accesses HttpServletRequest directly)
> -------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-540
> URL: https://issues.apache.org/jira/browse/WICKET-540
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.2.5
> Reporter: Seth Green
> Priority: Critical
>
> I'm running Wicket behind a front-end proxy. To fix certain issues with this I have set the ContextPath value in my application settings (and/or in Web.xml), However, when using functions that attempt to get at the context path (e.g. continueToOriginalDestination()) the app does not respect my setting.
> This is because in ServletWebRequest, getContextPath() directly accesses HttpServletRequest without checking the application settings.
> I believe it should first check the application settings, and only if ContextPath is /not/ set, then access the HttpServletRequest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.