You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/23 09:22:49 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #19727: Add test case for views connections muldelete function

uranusjr commented on a change in pull request #19727:
URL: https://github.com/apache/airflow/pull/19727#discussion_r754927793



##########
File path: tests/www/views/test_views_connection.py
##########
@@ -171,6 +171,7 @@ def test_duplicate_connection_error(admin_client):
     with create_session() as session:
         session.query(Connection).delete()
         session.add_all(connections)
+        session.commit()

Review comment:
       This should not be needed because `create_session` commits automatically on exit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org