You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by "cgivre (via GitHub)" <gi...@apache.org> on 2023/04/18 02:31:12 UTC

Re: [PR] DRILL-8393: Allow parameters to be passed to headers through SQL in WHERE clause (drill)

cgivre commented on PR #2747:
URL: https://github.com/apache/drill/pull/2747#issuecomment-1512348212

   @LYCJeff 
   Thank you for submitting this and I'm sorry the review is taking so long.  This is a potentially very breaking change and that's why I've had to give this so much thought.  I've also been quite busy.  Ok... 
   
   Let's get this merged.
   Here are my final requests:
   
   1.  Please rebase on current master
   2.  Can we make the default behavior what Drill currently does and change the boolean parameter to something like `enablePostHeadersInWhere` or something that uses the word `enable`?
   3. Make the default behavior to use the current implementation. 
   
   Once that's done, I'm good with merging.  
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org