You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Bill Bell (JIRA)" <ji...@apache.org> on 2011/02/28 05:23:36 UTC
[jira] Created: (SOLR-2393) Clean up Double Metaphone code
(PhoneticFilterFactory and DoubleMetaphoneFilter)
Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)
--------------------------------------------------------------------------------
Key: SOLR-2393
URL: https://issues.apache.org/jira/browse/SOLR-2393
Project: Solr
Issue Type: Improvement
Affects Versions: 4.0
Reporter: Bill Bell
>From Ryan McKinley to Jan Høydahl:
PhoneticFilterFactory could check
"DoubleMetaphone".equals( encoder ) and then create the specialized
Filter.
I don't feel strongly, but we could have:
EncoderFilter -- just uses 'encode()'
DoubleMetaphoneFilter - uses special double metaphone stuff
EncoderFilterFactory -- always uses EncoderFilter, and is not
semantically bound to 'phonetic'
PhoneticFilterFactory -- picks the best phonetic filter impl (encoder
or double metaphone)
then deprecate:
PhoneticFilter
DoubleMetaphoneFilterFactory
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2393) Clean up Double Metaphone code
(PhoneticFilterFactory and DoubleMetaphoneFilter)
Posted by "Bill Bell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217909#comment-13217909 ]
Bill Bell commented on SOLR-2393:
---------------------------------
Done.
> Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)
> --------------------------------------------------------------------------------
>
> Key: SOLR-2393
> URL: https://issues.apache.org/jira/browse/SOLR-2393
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Bill Bell
> Assignee: Jan Høydahl
> Attachments: SOLR-2393.patch
>
>
> From Ryan McKinley to Jan Høydahl:
> PhoneticFilterFactory could check
> "DoubleMetaphone".equals( encoder ) and then create the specialized
> Filter.
> I don't feel strongly, but we could have:
> EncoderFilter -- just uses 'encode()'
> DoubleMetaphoneFilter - uses special double metaphone stuff
> EncoderFilterFactory -- always uses EncoderFilter, and is not
> semantically bound to 'phonetic'
> PhoneticFilterFactory -- picks the best phonetic filter impl (encoder
> or double metaphone)
> then deprecate:
> PhoneticFilter
> DoubleMetaphoneFilterFactory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2393) Clean up Double Metaphone code
(PhoneticFilterFactory and DoubleMetaphoneFilter)
Posted by "Bill Bell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216796#comment-13216796 ]
Bill Bell commented on SOLR-2393:
---------------------------------
Jan...
So we would switch from -
{code}
<filter class="solr.PhoneticFilterFactory" encoder="DoubleMetaphone" inject="false"/>
or
<filter class="solr.DoubleMetaphoneFilterFactory" inject="false"/>
{code}
to the following...
So we would have these 2 cases? Is that how you understand it?
{code}
<fieldtype name="phonetic" stored="false" indexed="true" class="solr.TextField" >
<analyzer>
<tokenizer class="solr.StandardTokenizerFactory"/>
<filter class="solr.PhoneticFilterFactory" encoder="Phonetic" inject="false"/>
</analyzer>
</fieldtype>
<fieldtype name="phonetic" stored="false" indexed="true" class="solr.TextField" >
<analyzer>
<tokenizer class="solr.StandardTokenizerFactory"/>
<filter class="solr.PhoneticFilterFactory" encoder="DoubleMetaphone" inject="false"/>
</analyzer>
</fieldtype>
{code}
> Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)
> --------------------------------------------------------------------------------
>
> Key: SOLR-2393
> URL: https://issues.apache.org/jira/browse/SOLR-2393
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Bill Bell
>
> From Ryan McKinley to Jan Høydahl:
> PhoneticFilterFactory could check
> "DoubleMetaphone".equals( encoder ) and then create the specialized
> Filter.
> I don't feel strongly, but we could have:
> EncoderFilter -- just uses 'encode()'
> DoubleMetaphoneFilter - uses special double metaphone stuff
> EncoderFilterFactory -- always uses EncoderFilter, and is not
> semantically bound to 'phonetic'
> PhoneticFilterFactory -- picks the best phonetic filter impl (encoder
> or double metaphone)
> then deprecate:
> PhoneticFilter
> DoubleMetaphoneFilterFactory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2393) Clean up Double Metaphone code
(PhoneticFilterFactory and DoubleMetaphoneFilter)
Posted by "Bill Bell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Bell updated SOLR-2393:
----------------------------
Attachment: SOLR-2393.patch
> Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)
> --------------------------------------------------------------------------------
>
> Key: SOLR-2393
> URL: https://issues.apache.org/jira/browse/SOLR-2393
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Bill Bell
> Assignee: Jan Høydahl
> Attachments: SOLR-2393.patch
>
>
> From Ryan McKinley to Jan Høydahl:
> PhoneticFilterFactory could check
> "DoubleMetaphone".equals( encoder ) and then create the specialized
> Filter.
> I don't feel strongly, but we could have:
> EncoderFilter -- just uses 'encode()'
> DoubleMetaphoneFilter - uses special double metaphone stuff
> EncoderFilterFactory -- always uses EncoderFilter, and is not
> semantically bound to 'phonetic'
> PhoneticFilterFactory -- picks the best phonetic filter impl (encoder
> or double metaphone)
> then deprecate:
> PhoneticFilter
> DoubleMetaphoneFilterFactory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2393) Clean up Double Metaphone code
(PhoneticFilterFactory and DoubleMetaphoneFilter)
Posted by "Jan Høydahl (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217144#comment-13217144 ]
Jan Høydahl commented on SOLR-2393:
-----------------------------------
Hi, can you re-upload the patch with name SOLR-2393.patch ?
> Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)
> --------------------------------------------------------------------------------
>
> Key: SOLR-2393
> URL: https://issues.apache.org/jira/browse/SOLR-2393
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Bill Bell
> Assignee: Jan Høydahl
> Attachments: SOLR-2383.diff
>
>
> From Ryan McKinley to Jan Høydahl:
> PhoneticFilterFactory could check
> "DoubleMetaphone".equals( encoder ) and then create the specialized
> Filter.
> I don't feel strongly, but we could have:
> EncoderFilter -- just uses 'encode()'
> DoubleMetaphoneFilter - uses special double metaphone stuff
> EncoderFilterFactory -- always uses EncoderFilter, and is not
> semantically bound to 'phonetic'
> PhoneticFilterFactory -- picks the best phonetic filter impl (encoder
> or double metaphone)
> then deprecate:
> PhoneticFilter
> DoubleMetaphoneFilterFactory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2393) Clean up Double Metaphone code
(PhoneticFilterFactory and DoubleMetaphoneFilter)
Posted by "Jan Høydahl (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jan Høydahl updated SOLR-2393:
------------------------------
Assignee: (was: Jan Høydahl)
> Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)
> --------------------------------------------------------------------------------
>
> Key: SOLR-2393
> URL: https://issues.apache.org/jira/browse/SOLR-2393
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Bill Bell
> Attachments: SOLR-2393.patch
>
>
> From Ryan McKinley to Jan Høydahl:
> PhoneticFilterFactory could check
> "DoubleMetaphone".equals( encoder ) and then create the specialized
> Filter.
> I don't feel strongly, but we could have:
> EncoderFilter -- just uses 'encode()'
> DoubleMetaphoneFilter - uses special double metaphone stuff
> EncoderFilterFactory -- always uses EncoderFilter, and is not
> semantically bound to 'phonetic'
> PhoneticFilterFactory -- picks the best phonetic filter impl (encoder
> or double metaphone)
> then deprecate:
> PhoneticFilter
> DoubleMetaphoneFilterFactory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Assigned] (SOLR-2393) Clean up Double Metaphone code
(PhoneticFilterFactory and DoubleMetaphoneFilter)
Posted by "Bill Bell (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Bell reassigned SOLR-2393:
-------------------------------
Assignee: Jan Høydahl
> Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)
> --------------------------------------------------------------------------------
>
> Key: SOLR-2393
> URL: https://issues.apache.org/jira/browse/SOLR-2393
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Bill Bell
> Assignee: Jan Høydahl
>
> From Ryan McKinley to Jan Høydahl:
> PhoneticFilterFactory could check
> "DoubleMetaphone".equals( encoder ) and then create the specialized
> Filter.
> I don't feel strongly, but we could have:
> EncoderFilter -- just uses 'encode()'
> DoubleMetaphoneFilter - uses special double metaphone stuff
> EncoderFilterFactory -- always uses EncoderFilter, and is not
> semantically bound to 'phonetic'
> PhoneticFilterFactory -- picks the best phonetic filter impl (encoder
> or double metaphone)
> then deprecate:
> PhoneticFilter
> DoubleMetaphoneFilterFactory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2393) Clean up Double Metaphone code
(PhoneticFilterFactory and DoubleMetaphoneFilter)
Posted by "Jan Høydahl (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216951#comment-13216951 ]
Jan Høydahl commented on SOLR-2393:
-----------------------------------
I think the problem is that PhoneticFilterFactory does not handle DoubleMetaphone correctly, and to avoid confusion we should upgrade PhoneticFilterFactory to do DoubleMetaphone correctly and then deprecate DoubleMetaphoneFilterFactory.
> Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)
> --------------------------------------------------------------------------------
>
> Key: SOLR-2393
> URL: https://issues.apache.org/jira/browse/SOLR-2393
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Bill Bell
> Assignee: Jan Høydahl
>
> From Ryan McKinley to Jan Høydahl:
> PhoneticFilterFactory could check
> "DoubleMetaphone".equals( encoder ) and then create the specialized
> Filter.
> I don't feel strongly, but we could have:
> EncoderFilter -- just uses 'encode()'
> DoubleMetaphoneFilter - uses special double metaphone stuff
> EncoderFilterFactory -- always uses EncoderFilter, and is not
> semantically bound to 'phonetic'
> PhoneticFilterFactory -- picks the best phonetic filter impl (encoder
> or double metaphone)
> then deprecate:
> PhoneticFilter
> DoubleMetaphoneFilterFactory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2393) Clean up Double Metaphone code
(PhoneticFilterFactory and DoubleMetaphoneFilter)
Posted by "Bill Bell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233165#comment-13233165 ]
Bill Bell commented on SOLR-2393:
---------------------------------
Can someone please review my patch to see if it makes sense... ?
I am not an expert at these Phonetic filters. I think I nailed it, and it appears to work well.
> Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)
> --------------------------------------------------------------------------------
>
> Key: SOLR-2393
> URL: https://issues.apache.org/jira/browse/SOLR-2393
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Bill Bell
> Attachments: SOLR-2393.patch
>
>
> From Ryan McKinley to Jan Høydahl:
> PhoneticFilterFactory could check
> "DoubleMetaphone".equals( encoder ) and then create the specialized
> Filter.
> I don't feel strongly, but we could have:
> EncoderFilter -- just uses 'encode()'
> DoubleMetaphoneFilter - uses special double metaphone stuff
> EncoderFilterFactory -- always uses EncoderFilter, and is not
> semantically bound to 'phonetic'
> PhoneticFilterFactory -- picks the best phonetic filter impl (encoder
> or double metaphone)
> then deprecate:
> PhoneticFilter
> DoubleMetaphoneFilterFactory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-2393) Clean up Double Metaphone code
(PhoneticFilterFactory and DoubleMetaphoneFilter)
Posted by "Jan Høydahl (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213008#comment-13213008 ]
Jan Høydahl commented on SOLR-2393:
-----------------------------------
Hmm, was looking at phonetics a bit and found this issue. This should not be too hard, should it?
Bill, would you like to attempt a first patch?
> Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)
> --------------------------------------------------------------------------------
>
> Key: SOLR-2393
> URL: https://issues.apache.org/jira/browse/SOLR-2393
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Bill Bell
>
> From Ryan McKinley to Jan Høydahl:
> PhoneticFilterFactory could check
> "DoubleMetaphone".equals( encoder ) and then create the specialized
> Filter.
> I don't feel strongly, but we could have:
> EncoderFilter -- just uses 'encode()'
> DoubleMetaphoneFilter - uses special double metaphone stuff
> EncoderFilterFactory -- always uses EncoderFilter, and is not
> semantically bound to 'phonetic'
> PhoneticFilterFactory -- picks the best phonetic filter impl (encoder
> or double metaphone)
> then deprecate:
> PhoneticFilter
> DoubleMetaphoneFilterFactory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2393) Clean up Double Metaphone code
(PhoneticFilterFactory and DoubleMetaphoneFilter)
Posted by "Bill Bell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Bell updated SOLR-2393:
----------------------------
Attachment: (was: SOLR-2383.diff)
> Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)
> --------------------------------------------------------------------------------
>
> Key: SOLR-2393
> URL: https://issues.apache.org/jira/browse/SOLR-2393
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Bill Bell
> Assignee: Jan Høydahl
> Attachments: SOLR-2393.patch
>
>
> From Ryan McKinley to Jan Høydahl:
> PhoneticFilterFactory could check
> "DoubleMetaphone".equals( encoder ) and then create the specialized
> Filter.
> I don't feel strongly, but we could have:
> EncoderFilter -- just uses 'encode()'
> DoubleMetaphoneFilter - uses special double metaphone stuff
> EncoderFilterFactory -- always uses EncoderFilter, and is not
> semantically bound to 'phonetic'
> PhoneticFilterFactory -- picks the best phonetic filter impl (encoder
> or double metaphone)
> then deprecate:
> PhoneticFilter
> DoubleMetaphoneFilterFactory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2393) Clean up Double Metaphone code
(PhoneticFilterFactory and DoubleMetaphoneFilter)
Posted by "Bill Bell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Bell updated SOLR-2393:
----------------------------
Attachment: (was: SOLR-2383.patch)
> Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)
> --------------------------------------------------------------------------------
>
> Key: SOLR-2393
> URL: https://issues.apache.org/jira/browse/SOLR-2393
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Bill Bell
> Assignee: Jan Høydahl
> Attachments: SOLR-2393.patch
>
>
> From Ryan McKinley to Jan Høydahl:
> PhoneticFilterFactory could check
> "DoubleMetaphone".equals( encoder ) and then create the specialized
> Filter.
> I don't feel strongly, but we could have:
> EncoderFilter -- just uses 'encode()'
> DoubleMetaphoneFilter - uses special double metaphone stuff
> EncoderFilterFactory -- always uses EncoderFilter, and is not
> semantically bound to 'phonetic'
> PhoneticFilterFactory -- picks the best phonetic filter impl (encoder
> or double metaphone)
> then deprecate:
> PhoneticFilter
> DoubleMetaphoneFilterFactory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2393) Clean up Double Metaphone code
(PhoneticFilterFactory and DoubleMetaphoneFilter)
Posted by "Bill Bell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Bell updated SOLR-2393:
----------------------------
Attachment: SOLR-2383.diff
schema.phonetic.xml can be used for testing
Once this is good I'll deprecate solr/core/src/java/org/apache/solr/analysis/DoubleMetaphoneFilterFactory.java and fix the schema.xml test cases.
> Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)
> --------------------------------------------------------------------------------
>
> Key: SOLR-2393
> URL: https://issues.apache.org/jira/browse/SOLR-2393
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Bill Bell
> Assignee: Jan Høydahl
> Attachments: SOLR-2383.diff
>
>
> From Ryan McKinley to Jan Høydahl:
> PhoneticFilterFactory could check
> "DoubleMetaphone".equals( encoder ) and then create the specialized
> Filter.
> I don't feel strongly, but we could have:
> EncoderFilter -- just uses 'encode()'
> DoubleMetaphoneFilter - uses special double metaphone stuff
> EncoderFilterFactory -- always uses EncoderFilter, and is not
> semantically bound to 'phonetic'
> PhoneticFilterFactory -- picks the best phonetic filter impl (encoder
> or double metaphone)
> then deprecate:
> PhoneticFilter
> DoubleMetaphoneFilterFactory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-2393) Clean up Double Metaphone code
(PhoneticFilterFactory and DoubleMetaphoneFilter)
Posted by "Bill Bell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bill Bell updated SOLR-2393:
----------------------------
Attachment: SOLR-2383.patch
> Clean up Double Metaphone code (PhoneticFilterFactory and DoubleMetaphoneFilter)
> --------------------------------------------------------------------------------
>
> Key: SOLR-2393
> URL: https://issues.apache.org/jira/browse/SOLR-2393
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Bill Bell
> Assignee: Jan Høydahl
> Attachments: SOLR-2383.diff, SOLR-2383.patch
>
>
> From Ryan McKinley to Jan Høydahl:
> PhoneticFilterFactory could check
> "DoubleMetaphone".equals( encoder ) and then create the specialized
> Filter.
> I don't feel strongly, but we could have:
> EncoderFilter -- just uses 'encode()'
> DoubleMetaphoneFilter - uses special double metaphone stuff
> EncoderFilterFactory -- always uses EncoderFilter, and is not
> semantically bound to 'phonetic'
> PhoneticFilterFactory -- picks the best phonetic filter impl (encoder
> or double metaphone)
> then deprecate:
> PhoneticFilter
> DoubleMetaphoneFilterFactory
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org