You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "xiaoxuandev (via GitHub)" <gi...@apache.org> on 2026/03/11 21:43:14 UTC
[PR] [SPARK-55839] Add export config button to Environment page [spark]
xiaoxuandev opened a new pull request, #54762:
URL: https://github.com/apache/spark/pull/54762
### What changes were proposed in this pull request?
Added an "Export" button to the Spark Properties section of the Environment page UI. Clicking the button downloads the current Spark configuration as a `spark-defaults.conf` formatted file (key=value, one per line).
### Why are the changes needed?
Users often need to reproduce environments, share configs for debugging, or compare configurations between clusters. Currently there is no easy way to export the Spark properties from the UI — users have to manually copy them. This button provides a one-click export.
### Does this PR introduce _any_ user-facing change?
Yes. A new "Export" button appears above the Spark Properties table on the Environment page. Clicking it downloads a `spark-defaults.conf` file containing all Spark properties.
### How was this patch tested?
Manual testing: started `spark-shell`, navigated to `http://localhost:4040/environment/`, verified the Export button appears in the Spark Properties tab, and confirmed the downloaded file contains correct key=value formatted properties.
<img width="1506" height="757" alt="Screenshot 2026-03-11 at 2 33 28 PM" src="https://github.com/user-attachments/assets/52da589e-8ada-46f2-b66e-09c16146feab" />
### Was this patch authored or co-authored using generative AI tooling?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839] Add export config button to Environment page [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #54762:
URL: https://github.com/apache/spark/pull/54762#discussion_r2938607798
##########
core/src/main/resources/org/apache/spark/ui/static/environmentpage.js:
##########
@@ -77,6 +77,22 @@ function formatResourceProfile(rp) {
return lines.join("\n");
}
+function exportSparkProperties(sparkProps) {
+ var lines = sparkProps.map(function (prop) {
+ return prop[0] + "=" + prop[1];
+ });
+ var content = lines.join("\n") + "\n";
+ var blob = new Blob([content], { type: "text/plain;charset=utf-8" });
+ var url = URL.createObjectURL(blob);
+ var a = document.createElement("a");
+ a.href = url;
+ a.download = "spark-defaults.conf";
Review Comment:
another thought, `spark-defaults` might not be suitable here, the exported configuration actually contains some runtime-generated configs(e.g., `spark.app.id`), how about replacing `defaults` with `runtime`? or any other suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839] Add export config button to Environment page [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #54762:
URL: https://github.com/apache/spark/pull/54762#discussion_r2922092463
##########
core/src/main/resources/org/apache/spark/ui/static/environmentpage.js:
##########
@@ -77,6 +77,22 @@ function formatResourceProfile(rp) {
return lines.join("\n");
}
+function exportSparkProperties(sparkProps) {
+ var lines = sparkProps.map(function (prop) {
+ return prop[0] + "=" + prop[1];
+ });
+ var content = lines.join("\n") + "\n";
+ var blob = new Blob([content], { type: "text/plain;charset=utf-8" });
+ var url = URL.createObjectURL(blob);
+ var a = document.createElement("a");
+ a.href = url;
+ a.download = "spark-defaults.conf";
Review Comment:
is the filename `"spark-defaults.conf"`? how about `"${Utils.nameForAppAndAttempt}-spark-defaults.conf"`? similar to event log filename pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839] Add export config button to Environment page [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #54762:
URL: https://github.com/apache/spark/pull/54762#discussion_r2944012667
##########
core/src/main/resources/org/apache/spark/ui/static/environmentpage.js:
##########
@@ -77,6 +77,22 @@ function formatResourceProfile(rp) {
return lines.join("\n");
}
+function exportSparkProperties(sparkProps) {
+ var lines = sparkProps.map(function (prop) {
+ return prop[0] + "=" + prop[1];
+ });
+ var content = lines.join("\n") + "\n";
+ var blob = new Blob([content], { type: "text/plain;charset=utf-8" });
+ var url = URL.createObjectURL(blob);
+ var a = document.createElement("a");
+ a.href = url;
+ a.download = "spark-defaults.conf";
Review Comment:
I think the "Properties" refers to the format
https://docs.oracle.com/en/java/javase/25/docs/api/java.base/java/util/Properties.html
also, the "defaults" might also be brought from here
> A property list can contain another property list as its "defaults"; this second property list is searched if the property key is not found in the original property list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839] Add export config button to Environment page [spark]
Posted by "Xuefeng-Zhu (via GitHub)" <gi...@apache.org>.
Xuefeng-Zhu commented on code in PR #54762:
URL: https://github.com/apache/spark/pull/54762#discussion_r2934096688
##########
core/src/main/resources/org/apache/spark/ui/static/environmentpage.js:
##########
@@ -117,6 +133,15 @@ $(document).ready(function () {
});
getStandAloneAppId(function (appId) {
+ // Extract attemptId from history server URL if present
Review Comment:
This seems to duplicate with code in createRESTEndPointForEnvironmentPage at line 22. Please consider creating a helper function like
```js
function getAppAndAttemptFromUrl() {
var words = document.baseURI.split("/");
var appId = null;
var attemptId = null;
var ind = words.indexOf("proxy");
if (ind > 0) {
appId = words[ind + 1];
return { appId: appId, attemptId: attemptId };
}
ind = words.indexOf("history");
if (ind > 0) {
appId = words[ind + 1];
var possibleAttemptId = words[ind + 2];
if (!isNaN(possibleAttemptId)) {
attemptId = possibleAttemptId;
}
}
return { appId: appId, attemptId: attemptId };
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839][UI] Add export config button to Environment page [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #54762:
URL: https://github.com/apache/spark/pull/54762#issuecomment-4086279644
cc @yaooqinn too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839] Add export config button to Environment page [spark]
Posted by "Xuefeng-Zhu (via GitHub)" <gi...@apache.org>.
Xuefeng-Zhu commented on code in PR #54762:
URL: https://github.com/apache/spark/pull/54762#discussion_r2934111475
##########
core/src/main/resources/org/apache/spark/ui/static/environmentpage.js:
##########
@@ -117,6 +133,15 @@ $(document).ready(function () {
});
getStandAloneAppId(function (appId) {
+ // Extract attemptId from history server URL if present
+ var words = document.baseURI.split("/");
+ var ind = words.indexOf("history");
+ var attemptId;
+ if (ind > 0 && ind + 2 < words.length && !isNaN(words[ind + 2])) {
+ attemptId = words[ind + 2];
+ }
+ var exportFileName = appId + (attemptId ? "_" + attemptId : "") + "-spark-defaults.conf";
Review Comment:
exportFileName can be formed inside exportSparkProperties instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839][UI] Add export config button to Environment page [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #54762: [SPARK-55839][UI] Add export config button to Environment page
URL: https://github.com/apache/spark/pull/54762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839][UI] Add export config button to Environment page [spark]
Posted by "holdenk (via GitHub)" <gi...@apache.org>.
holdenk commented on PR #54762:
URL: https://github.com/apache/spark/pull/54762#issuecomment-4086280965
This is awesome. +1 on @yaooqinn if you've got cycles to take a look that would be great since you've been working on the UI more recenttly than me otherwise I can do a look too :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839] Add export config button to Environment page [spark]
Posted by "Xuefeng-Zhu (via GitHub)" <gi...@apache.org>.
Xuefeng-Zhu commented on code in PR #54762:
URL: https://github.com/apache/spark/pull/54762#discussion_r2934113994
##########
core/src/main/resources/org/apache/spark/ui/static/environmentpage.js:
##########
@@ -159,6 +184,19 @@ $(document).ready(function () {
updateBadge("spark-props-tab", sparkProps.length);
+ if (sparkProps.length > 0) {
+ var exportBtn = document.createElement("button");
+ exportBtn.type = "button";
+ exportBtn.className = "btn btn-sm btn-outline-primary mb-2";
+ exportBtn.id = "export-spark-props-btn";
+ exportBtn.textContent = "Export";
+ exportBtn.addEventListener("click", function () {
+ exportSparkProperties(sparkProps, exportFileName);
+ });
+ var sparkPropsPane = document.getElementById("spark-props");
+ sparkPropsPane.insertBefore(exportBtn, sparkPropsPane.firstChild);
Review Comment:
prefer jquery
js```
var exportBtn = $("<button>")
.addClass("btn btn-sm btn-outline-primary mb-2")
.text("Export")
.attr("title", "Download as spark-defaults.conf")
.on("click", function() {
exportSparkProperties(appId, sparkProps);
});
$("#spark-props").prepend(exportBtn);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839] Add export config button to Environment page [spark]
Posted by "Xuefeng-Zhu (via GitHub)" <gi...@apache.org>.
Xuefeng-Zhu commented on code in PR #54762:
URL: https://github.com/apache/spark/pull/54762#discussion_r2934096688
##########
core/src/main/resources/org/apache/spark/ui/static/environmentpage.js:
##########
@@ -117,6 +133,15 @@ $(document).ready(function () {
});
getStandAloneAppId(function (appId) {
+ // Extract attemptId from history server URL if present
Review Comment:
This seems to duplicate with code in createRESTEndPointForEnvironmentPage at line 22. Please consider creating a helper function like
`function getAppAndAttemptFromUrl() {
var words = document.baseURI.split("/");
var appId = null;
var attemptId = null;
var ind = words.indexOf("proxy");
if (ind > 0) {
appId = words[ind + 1];
return { appId: appId, attemptId: attemptId };
}
ind = words.indexOf("history");
if (ind > 0) {
appId = words[ind + 1];
var possibleAttemptId = words[ind + 2];
if (!isNaN(possibleAttemptId)) {
attemptId = possibleAttemptId;
}
}
return { appId: appId, attemptId: attemptId };
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839] Add export config button to Environment page [spark]
Posted by "xiaoxuandev (via GitHub)" <gi...@apache.org>.
xiaoxuandev commented on code in PR #54762:
URL: https://github.com/apache/spark/pull/54762#discussion_r2943329234
##########
core/src/main/resources/org/apache/spark/ui/static/environmentpage.js:
##########
@@ -77,6 +77,22 @@ function formatResourceProfile(rp) {
return lines.join("\n");
}
+function exportSparkProperties(sparkProps) {
+ var lines = sparkProps.map(function (prop) {
+ return prop[0] + "=" + prop[1];
+ });
+ var content = lines.join("\n") + "\n";
+ var blob = new Blob([content], { type: "text/plain;charset=utf-8" });
+ var url = URL.createObjectURL(blob);
+ var a = document.createElement("a");
+ a.href = url;
+ a.download = "spark-defaults.conf";
Review Comment:
Nice catch! How about spark-properties.conf? It matches the section name `Spark Properties`on the Environment page. Open to other suggestions too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839] Add export config button to Environment page [spark]
Posted by "xiaoxuandev (via GitHub)" <gi...@apache.org>.
xiaoxuandev commented on PR #54762:
URL: https://github.com/apache/spark/pull/54762#issuecomment-4071089170
Thanks @pan3793 for the review!
Hi @yaooqinn, would you mind taking a pass on this when you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839][UI] Add export config button to Environment page [spark]
Posted by "xiaoxuandev (via GitHub)" <gi...@apache.org>.
xiaoxuandev commented on PR #54762:
URL: https://github.com/apache/spark/pull/54762#issuecomment-4093401084
@yaooqinn I’ve attached it in the PR description. Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839] Add export config button to Environment page [spark]
Posted by "xiaoxuandev (via GitHub)" <gi...@apache.org>.
xiaoxuandev commented on code in PR #54762:
URL: https://github.com/apache/spark/pull/54762#discussion_r2931993365
##########
core/src/main/resources/org/apache/spark/ui/static/environmentpage.js:
##########
@@ -77,6 +77,22 @@ function formatResourceProfile(rp) {
return lines.join("\n");
}
+function exportSparkProperties(sparkProps) {
+ var lines = sparkProps.map(function (prop) {
+ return prop[0] + "=" + prop[1];
+ });
+ var content = lines.join("\n") + "\n";
+ var blob = new Blob([content], { type: "text/plain;charset=utf-8" });
+ var url = URL.createObjectURL(blob);
+ var a = document.createElement("a");
+ a.href = url;
+ a.download = "spark-defaults.conf";
Review Comment:
Good point, changed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839] Add export config button to Environment page [spark]
Posted by "Xuefeng-Zhu (via GitHub)" <gi...@apache.org>.
Xuefeng-Zhu commented on code in PR #54762:
URL: https://github.com/apache/spark/pull/54762#discussion_r2934121578
##########
core/src/main/resources/org/apache/spark/ui/static/environmentpage.js:
##########
@@ -77,6 +77,22 @@ function formatResourceProfile(rp) {
return lines.join("\n");
}
+function exportSparkProperties(sparkProps, fileName) {
+ var lines = sparkProps.map(function (prop) {
+ return prop[0] + "=" + prop[1];
Review Comment:
Consider escaping special characters in config values for robustness
```js
function escapeConfigValue(value) {
if (value == null) return "";
return String(value)
.replace(/\\/g, "\\\\")
.replace(/\n/g, "\\n")
.replace(/\r/g, "\\r")
.replace(/\t/g, "\\t");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839][UI] Add export config button to Environment page [spark]
Posted by "xiaoxuandev (via GitHub)" <gi...@apache.org>.
xiaoxuandev commented on code in PR #54762:
URL: https://github.com/apache/spark/pull/54762#discussion_r2962782717
##########
core/src/main/resources/org/apache/spark/ui/static/environmentpage.js:
##########
@@ -77,6 +77,22 @@ function formatResourceProfile(rp) {
return lines.join("\n");
}
+function exportSparkProperties(sparkProps) {
+ var lines = sparkProps.map(function (prop) {
+ return prop[0] + "=" + prop[1];
+ });
+ var content = lines.join("\n") + "\n";
+ var blob = new Blob([content], { type: "text/plain;charset=utf-8" });
+ var url = URL.createObjectURL(blob);
+ var a = document.createElement("a");
+ a.href = url;
+ a.download = "spark-defaults.conf";
Review Comment:
Got it, thanks for the context! I’ll keep the current filename.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839] Add export config button to Environment page [spark]
Posted by "Xuefeng-Zhu (via GitHub)" <gi...@apache.org>.
Xuefeng-Zhu commented on code in PR #54762:
URL: https://github.com/apache/spark/pull/54762#discussion_r2934113994
##########
core/src/main/resources/org/apache/spark/ui/static/environmentpage.js:
##########
@@ -159,6 +184,19 @@ $(document).ready(function () {
updateBadge("spark-props-tab", sparkProps.length);
+ if (sparkProps.length > 0) {
+ var exportBtn = document.createElement("button");
+ exportBtn.type = "button";
+ exportBtn.className = "btn btn-sm btn-outline-primary mb-2";
+ exportBtn.id = "export-spark-props-btn";
+ exportBtn.textContent = "Export";
+ exportBtn.addEventListener("click", function () {
+ exportSparkProperties(sparkProps, exportFileName);
+ });
+ var sparkPropsPane = document.getElementById("spark-props");
+ sparkPropsPane.insertBefore(exportBtn, sparkPropsPane.firstChild);
Review Comment:
prefer jquery
```js
var exportBtn = $("<button>")
.addClass("btn btn-sm btn-outline-primary mb-2")
.text("Export")
.attr("title", "Download as spark-defaults.conf")
.on("click", function() {
exportSparkProperties(appId, sparkProps);
});
$("#spark-props").prepend(exportBtn);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839] Add export config button to Environment page [spark]
Posted by "xiaoxuandev (via GitHub)" <gi...@apache.org>.
xiaoxuandev commented on code in PR #54762:
URL: https://github.com/apache/spark/pull/54762#discussion_r2938304636
##########
core/src/main/resources/org/apache/spark/ui/static/environmentpage.js:
##########
@@ -77,6 +77,22 @@ function formatResourceProfile(rp) {
return lines.join("\n");
}
+function exportSparkProperties(sparkProps, fileName) {
+ var lines = sparkProps.map(function (prop) {
+ return prop[0] + "=" + prop[1];
Review Comment:
Thanks for the review! Updated accordingly, along with a few other cleanups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839] Add export config button to Environment page [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #54762:
URL: https://github.com/apache/spark/pull/54762#issuecomment-4065649777
@xiaoxuandev, thanks for adding this feature. I have no more comments except for [the filename](https://github.com/apache/spark/pull/54762#discussion_r2938607798), it lgtm, but better get approval from a frontend expert before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55839][UI] Add export config button to Environment page [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #54762:
URL: https://github.com/apache/spark/pull/54762#issuecomment-4089489967
@xiaoxuandev mind to download a copy and attach it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org