(texera) branch gh-readonly-queue/main/pr-6465-d1ac3a3eaf0d49d7eb57565f040844abed6a711b created (now b943852992)

[gi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a change to branch gh-readonly-queue/main/pr-6465-d1ac3a3eaf0d49d7eb57565f040844abed6a711b
in repository https://gitbox.apache.org/repos/asf/texera.git


      at b943852992 test(frontend): add unit tests for UserQuotaService (#6465)

This branch includes the following new commits:

     new b943852992 test(frontend): add unit tests for UserQuotaService (#6465)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.

(texera) 01/01: test(frontend): add unit tests for UserQuotaService (#6465)

[gi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-6465-d1ac3a3eaf0d49d7eb57565f040844abed6a711b
in repository https://gitbox.apache.org/repos/asf/texera.git

commit b9438529924e19dbf58c7cc6717a55362913f1be
Author: Matthew B. <mg...@uci.edu>
AuthorDate: Thu Jul 16 22:21:19 2026 -0700

    test(frontend): add unit tests for UserQuotaService (#6465)
    
    ### What changes were proposed in this PR?
    - Adds user-quota.service.spec.ts covering UserQuotaService; no
    production code changed.
    - Verifies the created-datasets/workflows, access-workflows and
    quota-size GET endpoints and the delete-collection DELETE.
    - Covers a 500 error response on deleteExecutionCollection.
    ### Any related issues, documentation, discussions?
    Closes: #6453
    ### How was this PR tested?
    - Run `cd frontend && npx nx test gui
    --include="**/user-quota.service.spec.ts"`, expect 7 passed.
    - Full frontend suite runs in CI via `yarn test:ci`, selected by the
    auto-applied `frontend` label.
    ### Was this PR authored or co-authored using generative AI tooling?
    Co-authored with Claude Opus 4.8 in compliance with ASF
---
 .../service/user/quota/user-quota.service.spec.ts  | 125 +++++++++++++++++++++
 1 file changed, 125 insertions(+)

diff --git a/frontend/src/app/dashboard/service/user/quota/user-quota.service.spec.ts b/frontend/src/app/dashboard/service/user/quota/user-quota.service.spec.ts
new file mode 100644
index 0000000000..bb7a424909
--- /dev/null
+++ b/frontend/src/app/dashboard/service/user/quota/user-quota.service.spec.ts
@@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { HttpClientTestingModule, HttpTestingController } from "@angular/common/http/testing";
+import { TestBed } from "@angular/core/testing";
+import {
+  UserQuotaService,
+  USER_CREATED_DATASETS,
+  USER_CREATED_WORKFLOWS,
+  USER_ACCESS_WORKFLOWS,
+  USER_QUOTA_SIZE,
+  USER_DELETE_EXECUTION_COLLECTION,
+} from "./user-quota.service";
+import { DatasetQuota } from "src/app/dashboard/type/quota-statistic.interface";
+import { ExecutionQuota } from "../../../../common/type/user";
+
+describe("UserQuotaService", () => {
+  let service: UserQuotaService;
+  let httpMock: HttpTestingController;
+
+  beforeEach(() => {
+    TestBed.configureTestingModule({
+      imports: [HttpClientTestingModule],
+      providers: [UserQuotaService],
+    });
+    service = TestBed.inject(UserQuotaService);
+    httpMock = TestBed.inject(HttpTestingController);
+  });
+
+  afterEach(() => {
+    httpMock.verify();
+  });
+
+  it("should be created", () => {
+    expect(service).toBeTruthy();
+  });
+
+  it("getCreatedDatasets() GETs the created-datasets endpoint", () => {
+    const datasets: ReadonlyArray<DatasetQuota> = [
+      { did: 1, name: "dataset-a", creationTime: 1700000000000, size: 2048 },
+    ];
+    let result: ReadonlyArray<DatasetQuota> | undefined;
+
+    service.getCreatedDatasets(1).subscribe(r => (result = r));
+
+    const req = httpMock.expectOne(USER_CREATED_DATASETS);
+    expect(req.request.method).toEqual("GET");
+    req.flush(datasets);
+
+    expect(result).toEqual(datasets);
+  });
+
+  it("getCreatedWorkflows() GETs the created-workflows endpoint", () => {
+    const workflows = [{ wid: 1 } as any];
+    let result: readonly any[] | undefined;
+
+    service.getCreatedWorkflows(1).subscribe(r => (result = r));
+
+    const req = httpMock.expectOne(USER_CREATED_WORKFLOWS);
+    expect(req.request.method).toEqual("GET");
+    req.flush(workflows);
+
+    expect(result).toEqual(workflows);
+  });
+
+  it("getAccessWorkflows() GETs the access-workflows endpoint", () => {
+    let result: readonly number[] | undefined;
+    service.getAccessWorkflows(1).subscribe(r => (result = r));
+
+    const req = httpMock.expectOne(USER_ACCESS_WORKFLOWS);
+    expect(req.request.method).toEqual("GET");
+    req.flush([10, 20]);
+
+    expect(result).toEqual([10, 20]);
+  });
+
+  it("getExecutionQuota() GETs the quota-size endpoint", () => {
+    const quota: ReadonlyArray<ExecutionQuota> = [
+      { eid: 1, workflowId: 2, workflowName: "wf", resultBytes: 10, runTimeStatsBytes: 20, logBytes: 30 },
+    ];
+    let result: ReadonlyArray<ExecutionQuota> | undefined;
+
+    service.getExecutionQuota(1).subscribe(r => (result = r));
+
+    const req = httpMock.expectOne(USER_QUOTA_SIZE);
+    expect(req.request.method).toEqual("GET");
+    req.flush(quota);
+
+    expect(result).toEqual(quota);
+  });
+
+  it("deleteExecutionCollection() DELETEs the per-execution endpoint", () => {
+    service.deleteExecutionCollection(55).subscribe();
+
+    const req = httpMock.expectOne(`${USER_DELETE_EXECUTION_COLLECTION}/55`);
+    expect(req.request.method).toEqual("DELETE");
+    req.flush(null);
+  });
+
+  it("deleteExecutionCollection() handles a server error response", () => {
+    let errored = false;
+    service.deleteExecutionCollection(7).subscribe({ error: () => (errored = true) });
+
+    const req = httpMock.expectOne(`${USER_DELETE_EXECUTION_COLLECTION}/7`);
+    req.flush("boom", { status: 500, statusText: "Server Error" });
+
+    expect(errored).toBe(true);
+  });
+});