[GitHub] [solr] warperwolf commented on pull request #324: SOLR-14660 - move HDFS to a contrib module

[GitBox <gi...@apache.org>]

warperwolf commented on pull request #324:
URL: https://github.com/apache/solr/pull/324#issuecomment-1022685028


   > > (me) I'm most concerned with the apparent duplication of tons of Solr test configs. How can we avoid that?
   > 
   > I'd be a hack but I wonder if this contrib could declare a test resource "input" pointing to a sub-directory of solr-core test configs? I'd take almost any hack over duplicating all that test config.
   
   @dsmiley @risdenk @madrob in commit https://github.com/apache/solr/pull/324/commits/2ec7d59195238473a7e6e6e7c5fee0112cf20f40 I deleted all test resource files from the hdfs module and I added a gradle step to it which copies all the resource files from solr core's test-files to the build/resources/test directory of the hdfs module. A better solution could be to modify the test classes of the HDFS module to point to the resource files in the core's test-files directory, however the test base classes like SolrTestCaseJ4 load resources through the class loader (so that they end up being loaded from the build/resources/test directory of the module we are testing at the moment), and this resource loading seems to occur at various locations, so it would take some time to tweak these.  For now I'd suggest going with this resource copying solution and change the tests later in a separate ticket. (File copying occurs only on hdfs test execution, and this resolves the original issue of havi
 ng to maintain 2 set of resource files in git.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org