You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/27 07:34:57 UTC
[GitHub] [arrow-datafusion] isidentical opened a new pull request, #3280: Allow sorting by aggregated groups
isidentical opened a new pull request, #3280:
URL: https://github.com/apache/arrow-datafusion/pull/3280
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #2360.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
It seems like we used to only collect column references from the actual aggregate expressions, not the grouped expressions. This PR changes the processing of `rewrite_sort_col_by_aggs` to also include that fact.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Expression rewriter inside `rewrite_sort_col_by_aggs` now considers both distinct grouping expressions (e.g. `GROUP BY <something>`) as well as regular aggregate expressions when looking for a rewrite.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
This is a bug fix.
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3280: Allow sorting by aggregated groups
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3280:
URL: https://github.com/apache/arrow-datafusion/pull/3280#issuecomment-1229176746
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3280?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3280](https://codecov.io/gh/apache/arrow-datafusion/pull/3280?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6e6b674) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/eedc7874c4ed371d4df6f4b36690f78da82e2524?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eedc787) will **increase** coverage by `0.07%`.
> The diff coverage is `96.87%`.
```diff
@@ Coverage Diff @@
## master #3280 +/- ##
==========================================
+ Coverage 85.84% 85.92% +0.07%
==========================================
Files 291 294 +3
Lines 52981 53470 +489
==========================================
+ Hits 45484 45946 +462
- Misses 7497 7524 +27
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/3280?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/expr/src/expr\_rewriter.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3280/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9leHByX3Jld3JpdGVyLnJz) | `86.26% <80.00%> (+0.17%)` | :arrow_up: |
| [datafusion/core/tests/sql/group\_by.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3280/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3NxbC9ncm91cF9ieS5ycw==) | `96.91% <100.00%> (+0.27%)` | :arrow_up: |
| [datafusion/expr/src/logical\_plan/builder.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3280/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vYnVpbGRlci5ycw==) | `90.35% <100.00%> (ø)` | |
| [datafusion/core/tests/provider\_filter\_pushdown.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3280/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3Byb3ZpZGVyX2ZpbHRlcl9wdXNoZG93bi5ycw==) | `70.45% <0.00%> (-14.48%)` | :arrow_down: |
| [datafusion/core/src/physical\_plan/metrics/value.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3280/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL21ldHJpY3MvdmFsdWUucnM=) | `86.93% <0.00%> (-0.51%)` | :arrow_down: |
| [datafusion/core/src/datasource/view.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3280/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9kYXRhc291cmNlL3ZpZXcucnM=) | `86.54% <0.00%> (-0.08%)` | :arrow_down: |
| [datafusion/expr/src/function.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3280/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9mdW5jdGlvbi5ycw==) | `97.75% <0.00%> (ø)` | |
| [datafusion/core/src/datasource/file\_format/csv.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3280/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9kYXRhc291cmNlL2ZpbGVfZm9ybWF0L2Nzdi5ycw==) | `98.91% <0.00%> (ø)` | |
| [datafusion/physical-expr/src/expressions/column.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3280/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9waHlzaWNhbC1leHByL3NyYy9leHByZXNzaW9ucy9jb2x1bW4ucnM=) | `100.00% <0.00%> (ø)` | |
| [...fusion/optimizer/src/pre\_cast\_lit\_in\_comparison.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3280/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL3ByZV9jYXN0X2xpdF9pbl9jb21wYXJpc29uLnJz) | `91.95% <0.00%> (ø)` | |
| ... and [16 more](https://codecov.io/gh/apache/arrow-datafusion/pull/3280/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #3280: Allow sorting by aggregated groups
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #3280:
URL: https://github.com/apache/arrow-datafusion/pull/3280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3280: Allow sorting by aggregated groups
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3280:
URL: https://github.com/apache/arrow-datafusion/pull/3280#issuecomment-1232158137
Benchmark runs are scheduled for baseline = 7dedcb1963a3ff0c3ca276c43bff62373b608a4e and contender = 256ea91b1c0864449f9b41520c808695aa00460b. 256ea91b1c0864449f9b41520c808695aa00460b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/989b54b2ad964c81ad2d05de9dc5ad0a...3c4843bdf8f249dabd364b5a6c5f7a75/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ae8a8f9e76cc4fe5a19b9f9d3f37b788...2db8b3a6367445149f187879b29a2de1/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b2bf8e4f6e8d4d6ca805e2e4da82d977...d6111279778e495ab0cb9f2850600fb6/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c4b4dfb117ec439fa9d4bf4c1fa66bc8...f3b31991a81a4a8bb879bdbb94d903da/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org