You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/04/22 14:14:22 UTC

[GitHub] [openwhisk] rabbah commented on a change in pull request #4058: Add protect feature to avoid update or delete actions by mistake

rabbah commented on a change in pull request #4058:
URL: https://github.com/apache/openwhisk/pull/4058#discussion_r413017425



##########
File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/WhiskAction.scala
##########
@@ -55,7 +55,8 @@ case class WhiskActionPut(exec: Option[Exec] = None,
                           limits: Option[ActionLimitsOption] = None,
                           version: Option[SemVer] = None,
                           publish: Option[Boolean] = None,
-                          annotations: Option[Parameters] = None) {
+                          annotations: Option[Parameters] = None,
+                          unlock: Option[Boolean] = None) {

Review comment:
       concretely my suggestion is to change `unlock: Option[Boolean]` to `permissions: Option[Int]` and use bit operations to toggle permissions. The first set of permissions to respect is whether the resource is locked locked or unlocked. This can be abstracted with utility methods.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org