You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2015/09/13 19:12:39 UTC
hbase git commit: HBASE-14421 TestFastFail* are flakey; ADDENDUM
Repository: hbase
Updated Branches:
refs/heads/master 439ca071e -> e4e906f43
HBASE-14421 TestFastFail* are flakey; ADDENDUM
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/e4e906f4
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/e4e906f4
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/e4e906f4
Branch: refs/heads/master
Commit: e4e906f436894c6f7c2f8d389f43e2d3e8b6f391
Parents: 439ca07
Author: stack <st...@apache.org>
Authored: Sun Sep 13 10:12:30 2015 -0700
Committer: stack <st...@apache.org>
Committed: Sun Sep 13 10:12:30 2015 -0700
----------------------------------------------------------------------
.../java/org/apache/hadoop/hbase/client/TestFastFail.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/e4e906f4/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java
index f2eb8e0..da31a7d 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFastFail.java
@@ -268,18 +268,20 @@ public class TestFastFail {
assertEquals("The regionservers that returned true should equal to the"
+ " number of successful threads", numThreadsReturnedTrue,
numSuccessfullThreads.get());
+ assertTrue(
+ "There should be atleast one thread that retried instead of failing",
+ MyPreemptiveFastFailInterceptor.numBraveSouls.get() > 0);
+
/* 'should' is not worthy of an assert. Disabling because randomly this seems to randomly
* not but true. St.Ack 20151012
*
- * assertTrue(
- "There should be atleast one thread that retried instead of failing",
- MyPreemptiveFastFailInterceptor.numBraveSouls.get() > 0);*/
assertTrue(
"There should be atleast one PreemptiveFastFail exception,"
+ " otherwise, the test makes little sense."
+ "numPreemptiveFastFailExceptions: "
+ numPreemptiveFastFailExceptions.get(),
numPreemptiveFastFailExceptions.get() > 0);
+ */
assertTrue(
"Only few thread should ideally be waiting for the dead "
+ "regionserver to be coming back. numBlockedWorkers:"