You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/02 06:56:51 UTC
[jira] [Commented] (KAFKA-3896) Unstable test
KStreamRepartitionJoinTest.shouldCorrectlyRepartitionOnJoinOperations
[ https://issues.apache.org/jira/browse/KAFKA-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849536#comment-15849536 ]
ASF GitHub Bot commented on KAFKA-3896:
---------------------------------------
GitHub user guozhangwang opened a pull request:
https://github.com/apache/kafka/pull/2485
KAFKA-3896: Fix KStream-KStream leftJoin
The issue of transiently having duplicates is due to the bad design of the left join itself: in order to ignore the partial joined results such as `A:null`, it lets the producer to potentially send twice to source stream one and rely on all the following conditions to be true in order to pass the test:
1. `receiveMessages` happen to have fetched all the produced results and have committed offsets.
2. streams app happen to have completed sending all result data.
3. consumer used in `receiveMessages` will complete getting all messages in a single poll().
If any of the above is not true, the test fails.
Fixed this test to add a filter right after left join to filter out partial joined results. Minor cleanup on integration test utils.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guozhangwang/kafka K3896-duplicate-join-results
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2485.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2485
----
commit 186c32075bb8cab217dddeb23aa341fb3ac5e5d0
Author: Guozhang Wang <wa...@gmail.com>
Date: 2017-02-02T06:51:57Z
fix left join
----
> Unstable test KStreamRepartitionJoinTest.shouldCorrectlyRepartitionOnJoinOperations
> -----------------------------------------------------------------------------------
>
> Key: KAFKA-3896
> URL: https://issues.apache.org/jira/browse/KAFKA-3896
> Project: Kafka
> Issue Type: Sub-task
> Components: unit tests
> Reporter: Ashish Singh
> Assignee: Guozhang Wang
> Fix For: 0.10.2.0, 0.10.3.0
>
>
> {{KStreamRepartitionJoinTest.shouldCorrectlyRepartitionOnJoinOperations}} seems to be unstable. A failure can be found [here|https://builds.apache.org/job/kafka-trunk-git-pr-jdk7/4363/]. Could not reproduce the test failure locally though.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)