You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/10/02 22:51:50 UTC
[kudu-CR] [consensus] small clean-up on PendingRounds
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21878
Change subject: [consensus] small clean-up on PendingRounds
......................................................................
[consensus] small clean-up on PendingRounds
I was looking at the code around PendingRounds while troubleshooting
a race condition, and found that there is room for micro-optimisations
and syntactic sugar in the PendingRounds implementation.
This patch doesn't contain any functional modifications.
Change-Id: Iaa5b66d8a2cf179f43141de8d640251e1a2dc80f
---
M src/kudu/consensus/pending_rounds.cc
M src/kudu/consensus/pending_rounds.h
2 files changed, 20 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/21878/1
--
To view, visit http://gerrit.cloudera.org:8080/21878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa5b66d8a2cf179f43141de8d640251e1a2dc80f
Gerrit-Change-Number: 21878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [consensus] small clean-up on PendingRounds
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21878 )
Change subject: [consensus] small clean-up on PendingRounds
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/559/
--
To view, visit http://gerrit.cloudera.org:8080/21878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5b66d8a2cf179f43141de8d640251e1a2dc80f
Gerrit-Change-Number: 21878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Oct 2024 22:52:00 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] small clean-up on PendingRounds
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21878 )
Change subject: [consensus] small clean-up on PendingRounds
......................................................................
[consensus] small clean-up on PendingRounds
I was looking at the code around PendingRounds while troubleshooting
a race condition, and found that there is room for micro-optimisations
and syntactic sugar in the PendingRounds implementation.
This patch doesn't contain any functional modifications.
Change-Id: Iaa5b66d8a2cf179f43141de8d640251e1a2dc80f
Reviewed-on: http://gerrit.cloudera.org:8080/21878
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/consensus/pending_rounds.cc
M src/kudu/consensus/pending_rounds.h
2 files changed, 20 insertions(+), 18 deletions(-)
Approvals:
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/21878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa5b66d8a2cf179f43141de8d640251e1a2dc80f
Gerrit-Change-Number: 21878
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [consensus] small clean-up on PendingRounds
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21878 )
Change subject: [consensus] small clean-up on PendingRounds
......................................................................
Patch Set 1: Verified+1
Unrelated Java test failures in DEBUG and RELEASE builds.
Unrelated SanitizerWarnings in TSAN build.
--
To view, visit http://gerrit.cloudera.org:8080/21878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5b66d8a2cf179f43141de8d640251e1a2dc80f
Gerrit-Change-Number: 21878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 03 Oct 2024 01:14:17 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] small clean-up on PendingRounds
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21878 )
Change subject: [consensus] small clean-up on PendingRounds
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/559/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5b66d8a2cf179f43141de8d640251e1a2dc80f
Gerrit-Change-Number: 21878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 03 Oct 2024 01:01:04 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] small clean-up on PendingRounds
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21878 )
Change subject: [consensus] small clean-up on PendingRounds
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa5b66d8a2cf179f43141de8d640251e1a2dc80f
Gerrit-Change-Number: 21878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 03 Oct 2024 17:45:44 +0000
Gerrit-HasComments: No
[kudu-CR] [consensus] small clean-up on PendingRounds
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [consensus] small clean-up on PendingRounds
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21878
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Iaa5b66d8a2cf179f43141de8d640251e1a2dc80f
Gerrit-Change-Number: 21878
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>