You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "s7monk (via GitHub)" <gi...@apache.org> on 2024/05/27 02:25:19 UTC
[PR] [BugFix] Fix Cluster's listClusters interface [paimon-webui]
s7monk opened a new pull request, #256:
URL: https://github.com/apache/paimon-webui/pull/256
close: https://github.com/apache/paimon-webui/issues/255
### Purpose
When adding filter conditions when calling the listClusters interface of Cluster, an error will be reported because the query in ClusterMapper.xml does not add where conditions.This PR fixes the problem.
### Tests
ClusterControllerTest#testListClusters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BugFix] Fix Cluster's listClusters interface [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #256:
URL: https://github.com/apache/paimon-webui/pull/256#discussion_r1615429523
##########
paimon-web-server/src/test/java/org/apache/paimon/web/server/controller/ClusterControllerTest.java:
##########
@@ -100,10 +100,13 @@ public void testGetCluster() throws Exception {
@Test
@Order(3)
public void testListClusters() throws Exception {
+ ClusterInfo cluster = new ClusterInfo();
Review Comment:
I don't think this test case has verified above changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BugFix] Fix Cluster's listClusters interface [paimon-webui]
Posted by "s7monk (via GitHub)" <gi...@apache.org>.
s7monk commented on code in PR #256:
URL: https://github.com/apache/paimon-webui/pull/256#discussion_r1615436462
##########
paimon-web-server/src/test/java/org/apache/paimon/web/server/controller/ClusterControllerTest.java:
##########
@@ -100,10 +100,13 @@ public void testGetCluster() throws Exception {
@Test
@Order(3)
public void testListClusters() throws Exception {
+ ClusterInfo cluster = new ClusterInfo();
Review Comment:
Thanks for the review. The previous mapper xml was wrong. There was no where tag, so if you add filter conditions when disconnecting the interface, an error will be reported. This pr only added the where tag, test test. A filter condition of type Flink was passed, which is currently working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Bugfix] Fix condition of listClusters in ClusterMapper.xml [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas merged PR #256:
URL: https://github.com/apache/paimon-webui/pull/256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BugFix] Fix Cluster's listClusters interface [paimon-webui]
Posted by "s7monk (via GitHub)" <gi...@apache.org>.
s7monk commented on code in PR #256:
URL: https://github.com/apache/paimon-webui/pull/256#discussion_r1616649783
##########
paimon-web-server/src/test/java/org/apache/paimon/web/server/controller/ClusterControllerTest.java:
##########
@@ -100,10 +100,13 @@ public void testGetCluster() throws Exception {
@Test
@Order(3)
public void testListClusters() throws Exception {
+ ClusterInfo cluster = new ClusterInfo();
Review Comment:
You are right. The previous test cannot verify the above changes. I have corrected this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BugFix] Fix Cluster's listClusters interface [paimon-webui]
Posted by "s7monk (via GitHub)" <gi...@apache.org>.
s7monk commented on code in PR #256:
URL: https://github.com/apache/paimon-webui/pull/256#discussion_r1615435322
##########
paimon-web-server/src/test/java/org/apache/paimon/web/server/controller/ClusterControllerTest.java:
##########
@@ -100,10 +100,13 @@ public void testGetCluster() throws Exception {
@Test
@Order(3)
public void testListClusters() throws Exception {
+ ClusterInfo cluster = new ClusterInfo();
Review Comment:
Thanks for the review. The previous mapper xml was wrong. There was no <where></where> tag, so if you add filter conditions when disconnecting the interface, an error will be reported. This pr only added the <where></where> tag, test test. A filter condition of type Flink was passed, which is currently working.
##########
paimon-web-server/src/test/java/org/apache/paimon/web/server/controller/ClusterControllerTest.java:
##########
@@ -100,10 +100,13 @@ public void testGetCluster() throws Exception {
@Test
@Order(3)
public void testListClusters() throws Exception {
+ ClusterInfo cluster = new ClusterInfo();
Review Comment:
Thanks for the review. The previous mapper xml was wrong. There was no <where></where> tag, so if you add filter conditions when disconnecting the interface, an error will be reported. This pr only added the <where></where> tag, test test. A filter condition of type Flink was passed, which is currently working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BugFix] Fix Cluster's listClusters interface [paimon-webui]
Posted by "s7monk (via GitHub)" <gi...@apache.org>.
s7monk commented on code in PR #256:
URL: https://github.com/apache/paimon-webui/pull/256#discussion_r1615435322
##########
paimon-web-server/src/test/java/org/apache/paimon/web/server/controller/ClusterControllerTest.java:
##########
@@ -100,10 +100,13 @@ public void testGetCluster() throws Exception {
@Test
@Order(3)
public void testListClusters() throws Exception {
+ ClusterInfo cluster = new ClusterInfo();
Review Comment:
Thanks for the review. The previous mapper xml was wrong. There was no <where></where> tag, so if you add filter conditions when disconnecting the interface, an error will be reported. This pr only added the <where></where> tag, test test. A filter condition of type Flink was passed, which is currently working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BugFix] Fix Cluster's listClusters interface [paimon-webui]
Posted by "s7monk (via GitHub)" <gi...@apache.org>.
s7monk commented on code in PR #256:
URL: https://github.com/apache/paimon-webui/pull/256#discussion_r1615436076
##########
paimon-web-server/src/test/java/org/apache/paimon/web/server/controller/ClusterControllerTest.java:
##########
@@ -100,10 +100,13 @@ public void testGetCluster() throws Exception {
@Test
@Order(3)
public void testListClusters() throws Exception {
+ ClusterInfo cluster = new ClusterInfo();
Review Comment:
Thanks for the review. The previous mapper xml was wrong. There was no <where></where> tag, so if you add filter conditions when disconnecting the interface, an error will be reported. This pr only added the <where></where> tag, test test. A filter condition of type Flink was passed, which is currently working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [BugFix] Fix Cluster's listClusters interface [paimon-webui]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #256:
URL: https://github.com/apache/paimon-webui/pull/256#discussion_r1615630350
##########
paimon-web-server/src/test/java/org/apache/paimon/web/server/controller/ClusterControllerTest.java:
##########
@@ -100,10 +100,13 @@ public void testGetCluster() throws Exception {
@Test
@Order(3)
public void testListClusters() throws Exception {
+ ClusterInfo cluster = new ClusterInfo();
Review Comment:
Why not this test case verify that the previous mapper xml was wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org