[GitHub] [fineract] vorburger commented on pull request #1100: FINERACT-1047 Integration test for Audit trails(Create)

[GitBox <gi...@apache.org>]

vorburger commented on pull request #1100:
URL: https://github.com/apache/fineract/pull/1100#issuecomment-648330083


   @thesmallstar yes that's a very good point.. you are absolutely right, of course, this test could fail if it runs against a DB that already contains data, for example if it runs after other tests, which makes it potentially flaky and brittle. Change it like you suggested! Maybe instead of only testing that it's +1 more, you could assert on the content of the audit record itself as well?
   
   PS: There's a bigger issue about test isolation underlying this, but we're not going to solve this here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org