You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by dk...@apache.org on 2009/02/11 21:49:48 UTC
svn commit: r743501 - in /cxf/branches/2.1.x-fixes: ./
rt/core/src/main/java/org/apache/cxf/interceptor/
rt/core/src/main/java/org/apache/cxf/service/invoker/
rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/
Author: dkulp
Date: Wed Feb 11 20:49:48 2009
New Revision: 743501
URL: http://svn.apache.org/viewvc?rev=743501&view=rev
Log:
Merged revisions 743087 via svnmerge from
https://svn.apache.org/repos/asf/cxf/trunk
........
r743087 | dkulp | 2009-02-10 15:29:03 -0500 (Tue, 10 Feb 2009) | 3 lines
[CXF-973, CXF-2025] Fixes for various fault related issues
Patches from Will Gomes and Kaj Kandler applied
........
Modified:
cxf/branches/2.1.x-fixes/ (props changed)
cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/interceptor/ClientFaultConverter.java
cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/service/invoker/AbstractInvoker.java
cxf/branches/2.1.x-fixes/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WebFaultOutInterceptor.java
Propchange: cxf/branches/2.1.x-fixes/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Feb 11 20:49:48 2009
@@ -1 +1 @@
-/cxf/trunk:686333-686363,686764,686820,687096,687194,687363,687387,687463,687543,687722,687798,687814,687817,687891,687910,687914,688086,688102,688133,688596,688735,688870,689572,689596,689855,689924,690067,690289,691246,691271,691295,691338,691355,691488,691602,691646,691706,691728,692116,692157,692310,692466,692499,693653,693819,694179,694263,694417,694716,694744,694747,694795,694869,694981,694987,694993,695041,695096,695396,695484,695537,695552,695561,695619,695684,695835,695840,695868,695935,695977,696016,696094,696433,696720,697085,697868,698128,699289,700261,700507,700602,700981,701316,701783,701830,701862,702187,702205-702248,702267,702547,702561,702580,702602,702609,702616,702653,702656,702957,703191,703239,703309,703501,703513,703548,704584,704937,704997,705150,705235,705274,705340,705446,705548,705614,705692,705708,706482,706631,706675,706900,706909,707034,707089,707100,707902,708035,708044,708074,708410,708417,708550,708554,709353-709354,709425,710076,710150,71015
4,711193,711388,711410,711490,711635,711949,711975,712194,712198,712238,712272,712299,712312,712670,712893,713082,713095-713096,713099,713584,713597,713737,713804,713899,714167-714168,714245,714255,717937-717961,718281-718448,718565,718620,718640,718665,718970,719017,719210,719215-719218,719222-719273,719305,719327-719680,720053,720119-720218,720238,720293-720316,720497,721221,721241,721501,722117,722129,722412,722988,723024,723338,723378,723716-723791,724333-724372,724433-724438,724449,724481,724485,724668,724780,724782,724785,724793,724795,724940,725071,725316,725332,725335,725348,725364,725418,725425-725426,725455,725506,725554,725562,725651,725671,725688,725754,725773,725799,725839,726342,726524,726631,726634,726637,726639,726692,726724,726769,726992,727096,727445,727521,727568,727692,727754,727781,727792,728070,728087,728696,728897,729051,729430,729449,729460,729863,730082,730139,730889,730891,731598,731604,731615,731631,731635,732036,732050,732320,732363,732411,732450,
732710,732773,732827,732829,733512,733582,733901,734367,734462,734666,734762,734772,734812,734836,734965,735113,735252,735722-735723,735729,735734,735751,735782,735787,735987,736332,736343,736352,736358-736362,736408,736423,736448,736491,736621,736726,736736,736738-736739,736766,736825,736852,737032,737046,737061,737069,737124,737237,737246,737299,737356,737494,737498,737761,737817,737849,737855,737994,738166,738178,738201,738210,738242,738244,738265,738516,738583,738863,738937,738983,739366-739367,739451-739452,739799-739800,739867,739876-739877,739922,739937,739990,740045,740108,740154,740186,740197,740255,740706,740730,740810,740844,740886,740902,740923,740994,741058,741124,741152,741188,741521,741529,741879,742914
+/cxf/trunk:686333-686363,686764,686820,687096,687194,687363,687387,687463,687543,687722,687798,687814,687817,687891,687910,687914,688086,688102,688133,688596,688735,688870,689572,689596,689855,689924,690067,690289,691246,691271,691295,691338,691355,691488,691602,691646,691706,691728,692116,692157,692310,692466,692499,693653,693819,694179,694263,694417,694716,694744,694747,694795,694869,694981,694987,694993,695041,695096,695396,695484,695537,695552,695561,695619,695684,695835,695840,695868,695935,695977,696016,696094,696433,696720,697085,697868,698128,699289,700261,700507,700602,700981,701316,701783,701830,701862,702187,702205-702248,702267,702547,702561,702580,702602,702609,702616,702653,702656,702957,703191,703239,703309,703501,703513,703548,704584,704937,704997,705150,705235,705274,705340,705446,705548,705614,705692,705708,706482,706631,706675,706900,706909,707034,707089,707100,707902,708035,708044,708074,708410,708417,708550,708554,709353-709354,709425,710076,710150,71015
4,711193,711388,711410,711490,711635,711949,711975,712194,712198,712238,712272,712299,712312,712670,712893,713082,713095-713096,713099,713584,713597,713737,713804,713899,714167-714168,714245,714255,717937-717961,718281-718448,718565,718620,718640,718665,718970,719017,719210,719215-719218,719222-719273,719305,719327-719680,720053,720119-720218,720238,720293-720316,720497,721221,721241,721501,722117,722129,722412,722988,723024,723338,723378,723716-723791,724333-724372,724433-724438,724449,724481,724485,724668,724780,724782,724785,724793,724795,724940,725071,725316,725332,725335,725348,725364,725418,725425-725426,725455,725506,725554,725562,725651,725671,725688,725754,725773,725799,725839,726342,726524,726631,726634,726637,726639,726692,726724,726769,726992,727096,727445,727521,727568,727692,727754,727781,727792,728070,728087,728696,728897,729051,729430,729449,729460,729863,730082,730139,730889,730891,731598,731604,731615,731631,731635,732036,732050,732320,732363,732411,732450,
732710,732773,732827,732829,733512,733582,733901,734367,734462,734666,734762,734772,734812,734836,734965,735113,735252,735722-735723,735729,735734,735751,735782,735787,735987,736332,736343,736352,736358-736362,736408,736423,736448,736491,736621,736726,736736,736738-736739,736766,736825,736852,737032,737046,737061,737069,737124,737237,737246,737299,737356,737494,737498,737761,737817,737849,737855,737994,738166,738178,738201,738210,738242,738244,738265,738516,738583,738863,738937,738983,739366-739367,739451-739452,739799-739800,739867,739876-739877,739922,739937,739990,740045,740108,740154,740186,740197,740255,740706,740730,740810,740844,740886,740902,740923,740994,741058,741124,741152,741188,741521,741529,741879,742914,743087
Propchange: cxf/branches/2.1.x-fixes/
------------------------------------------------------------------------------
Binary property 'svnmerge-integrated' - no diff available.
Modified: cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/interceptor/ClientFaultConverter.java
URL: http://svn.apache.org/viewvc/cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/interceptor/ClientFaultConverter.java?rev=743501&r1=743500&r2=743501&view=diff
==============================================================================
--- cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/interceptor/ClientFaultConverter.java (original)
+++ cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/interceptor/ClientFaultConverter.java Wed Feb 11 20:49:48 2009
@@ -20,6 +20,7 @@
import java.lang.reflect.Constructor;
import java.lang.reflect.Field;
+import java.lang.reflect.Method;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
@@ -148,8 +149,14 @@
Constructor constructor = exClass.getConstructor(new Class[]{String.class});
e = constructor.newInstance(new Object[]{fault.getMessage()});
} else {
- Constructor constructor = getConstructor(exClass, e);
- e = constructor.newInstance(new Object[]{fault.getMessage(), e});
+
+ try {
+ Constructor constructor = getConstructor(exClass, e);
+ e = constructor.newInstance(new Object[]{fault.getMessage(), e});
+ } catch (NoSuchMethodException e1) {
+ //Use reflection to convert fault bean to exception
+ e = convertFaultBean(exClass, e, fault);
+ }
}
msg.setContent(Exception.class, e);
} catch (Exception e1) {
@@ -243,4 +250,47 @@
}
return null;
}
+
+ private Exception convertFaultBean(Class<?> exClass, Object faultBean, Fault fault) throws Exception {
+ Constructor constructor = exClass.getConstructor(new Class[]{String.class});
+ Exception e = (Exception)constructor.newInstance(new Object[]{fault.getMessage()});
+
+ //Copy fault bean fields to exception
+ for (Class<?> obj = exClass; !obj.equals(Object.class); obj = obj.getSuperclass()) {
+ Field[] fields = obj.getDeclaredFields();
+ for (Field f : fields) {
+ try {
+ Field beanField = faultBean.getClass().getDeclaredField(f.getName());
+ beanField.setAccessible(true);
+ f.setAccessible(true);
+ f.set(e, beanField.get(faultBean));
+ } catch (NoSuchFieldException e1) {
+ //do nothing
+ }
+ }
+ }
+ //also use/try public getter/setter methods
+ Method meth[] = faultBean.getClass().getMethods();
+ for (Method m : meth) {
+ if (m.getParameterTypes().length == 0
+ && (m.getName().startsWith("get")
+ || m.getName().startsWith("is"))) {
+ try {
+ String name;
+ if (m.getName().startsWith("get")) {
+ name = "set" + m.getName().substring(3);
+ } else {
+ name = "set" + m.getName().substring(2);
+ }
+ Method m2 = exClass.getMethod(name, m.getReturnType());
+ m2.invoke(e, m.invoke(faultBean));
+ } catch (Exception e1) {
+ //ignore
+ }
+ }
+ }
+
+
+ return e;
+ }
}
Modified: cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/service/invoker/AbstractInvoker.java
URL: http://svn.apache.org/viewvc/cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/service/invoker/AbstractInvoker.java?rev=743501&r1=743500&r2=743501&view=diff
==============================================================================
--- cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/service/invoker/AbstractInvoker.java (original)
+++ cxf/branches/2.1.x-fixes/rt/core/src/main/java/org/apache/cxf/service/invoker/AbstractInvoker.java Wed Feb 11 20:49:48 2009
@@ -147,10 +147,11 @@
if (checked) {
return new Fault(ex);
} else {
- return new Fault(new Message("EXCEPTION_INVOKING_OBJECT",
- LOG,
- ex.getMessage(), m.toString(), params),
- ex);
+ String message = (ex == null) ? "" : ex.getMessage();
+ String method = (m == null) ? "<null>" : m.toString();
+ return new Fault(new Message("EXCEPTION_INVOKING_OBJECT", LOG,
+ message, method, params),
+ ex);
}
}
Modified: cxf/branches/2.1.x-fixes/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WebFaultOutInterceptor.java
URL: http://svn.apache.org/viewvc/cxf/branches/2.1.x-fixes/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WebFaultOutInterceptor.java?rev=743501&r1=743500&r2=743501&view=diff
==============================================================================
--- cxf/branches/2.1.x-fixes/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WebFaultOutInterceptor.java (original)
+++ cxf/branches/2.1.x-fixes/rt/frontend/jaxws/src/main/java/org/apache/cxf/jaxws/interceptors/WebFaultOutInterceptor.java Wed Feb 11 20:49:48 2009
@@ -141,15 +141,13 @@
&& (m.getName().startsWith("get")
|| m.getName().startsWith("is"))) {
try {
- Method m2 = cls.getMethod(m.getName(),
- m.getParameterTypes());
String name;
if (m.getName().startsWith("get")) {
name = "set" + m.getName().substring(3);
} else {
name = "set" + m.getName().substring(2);
}
- m2 = cls.getMethod(name, m.getReturnType());
+ Method m2 = cls.getMethod(name, m.getReturnType());
m2.invoke(ret, m.invoke(cause));
} catch (Exception e) {
//ignore