You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by joewitt <gi...@git.apache.org> on 2017/12/06 08:23:21 UTC

[GitHub] nifi pull request #2320: NIFI-2375 updated to latest Tika across codebase. F...

GitHub user joewitt opened a pull request:

    https://github.com/apache/nifi/pull/2320

    NIFI-2375 updated to latest Tika across codebase.  Fixed

     tests and updated L&N for Tika parsers.  Turned unstable grpc test to IT
     test. Updated deps due to Tika testing findings
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/joewitt/incubator-nifi NIFI-2375

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2320.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2320
    
----
commit 3131ea1f8f7721d39f14ce7c6ef8c95d2a595a15
Author: joewitt <jo...@apache.org>
Date:   2017-12-06T08:05:20Z

    NIFI-2375 updated to latest Tika across codebase.  Fixed
     tests and updated L&N for Tika parsers.  Turned unstable grpc test to IT
     test. Updated deps due to Tika testing findings

----


---

[GitHub] nifi issue #2320: NIFI-2375 updated to latest Tika across codebase. Fixed

Posted by mcgilman <gi...@git.apache.org>.

Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/2320
  
    Thanks @joewitt! This has been merged to master.


---

[GitHub] nifi issue #2320: NIFI-2375 updated to latest Tika across codebase. Fixed

Posted by mcgilman <gi...@git.apache.org>.

Github user mcgilman commented on the issue:

    https://github.com/apache/nifi/pull/2320
  
    Will review...


---

[GitHub] nifi pull request #2320: NIFI-2375 updated to latest Tika across codebase. F...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/2320


---