[GitHub] arpadboda commented on a change in pull request #460: MINIFICPP-479: Add processor property descriptor updates. WIP

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #460: MINIFICPP-479: Add processor property descriptor updates. WIP
URL: https://github.com/apache/nifi-minifi-cpp/pull/460#discussion_r241747684
 
 

 ##########
 File path: libminifi/include/core/FlowConfiguration.h
 ##########
 @@ -70,7 +70,11 @@ class FlowConfiguration : public CoreComponent {
         logger_(logging::LoggerFactory<FlowConfiguration>::getLogger()) {
     controller_services_ = std::make_shared<core::controller::ControllerServiceMap>();
     service_provider_ = std::make_shared<core::controller::StandardControllerServiceProvider>(controller_services_, nullptr, configuration);
-    flow_version_ = std::make_shared<state::response::FlowVersion>("", "default", "");
+    std::string flowUrl = "", bucket_id = "default", flowId = "";
 
 Review comment:
   String are default constructed as empty, why do we need this? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services