[GitHub] [spark] HeartSaVioR commented on issue #27834: [SPARK-31091] Revert SPARK-24640 Return `NULL` from `size(NULL)` by default

[GitBox <gi...@apache.org>]

HeartSaVioR commented on issue #27834: [SPARK-31091] Revert SPARK-24640 Return `NULL` from `size(NULL)` by default
URL: https://github.com/apache/spark/pull/27834#issuecomment-598538807
 
 
   Btw, the configuration name `spark.sql.legacy.sizeOfNull` doesn't seem to be intuitive. It doesn't contain the information how it will behave. It's more confusing because now the default is true even the configuration is to retain legacy behavior.
   
   How about renaming it as `spark.sql.legacy.sizeOfNullAsMinusOne` and set it to true (so that no translation is needed)? Personally I prefer `spark.sql.legacy.sizeOfNullAsNull` and set it to false (so that we need to reverse in translation) so either is fine for me. Once we make configuration be intuitive we could guide to use it instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org