You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@iotdb.apache.org by "黄志洋 (Jira)" <ji...@apache.org> on 2022/01/10 13:27:00 UTC

[jira] [Commented] (IOTDB-2235) Optimize the constructor of InsertRowsOfOneDevicePlan

    [ https://issues.apache.org/jira/browse/IOTDB-2235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471996#comment-17471996 ] 

黄志洋 commented on IOTDB-2235:
----------------------------

i want to do this issue 

> Optimize the constructor of InsertRowsOfOneDevicePlan
> -----------------------------------------------------
>
>                 Key: IOTDB-2235
>                 URL: https://issues.apache.org/jira/browse/IOTDB-2235
>             Project: Apache IoTDB
>          Issue Type: Improvement
>          Components: Core/Engine
>            Reporter: Haonan Hou
>            Priority: Minor
>              Labels: easy-fix
>
> Currently the constructor of InsertRowsOfOneDevicePlan is 
> {code:java}
> public InsertRowsOfOneDevicePlan(
> PartialPath deviceId,
> Long[] insertTimes,
> List<List<String>> measurements,
> ByteBuffer[] insertValues)
> throws QueryProcessException {}{code}
> We can change it to 
> {code:java}
> public InsertRowsOfOneDevicePlan(
> PartialPath deviceId,
> List<Long> insertTimes,
> List<List<String>> measurements,
> List<ByteBuffer> insertValues)
> throws QueryProcessException {}{code}
> So that we don't need to call toArray in TSServiceImpl when construct the new InsertRowsOfOneDevicePlan. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)