[GitHub] [incubator-doris] morrySnow commented on a diff in pull request #10040: [Bug] [Vectorized] code dump on aggregate node over union node

[GitBox <gi...@apache.org>]

morrySnow commented on code in PR #10040:
URL: https://github.com/apache/incubator-doris/pull/10040#discussion_r893411150


##########
fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java:
##########
@@ -283,14 +283,12 @@ private boolean isChildPassthrough(
             if (childSlotRef == null) {
                 return false;
             }
-            if (VectorizedUtil.isVectorized()) {
-                if (childSlotRef.getDesc().getSlotOffset() != setOpSlotRef.getDesc().getSlotOffset()) {
-                    return false;
-                }
-            } else {
-                if (!childSlotRef.getDesc().layoutEquals(setOpSlotRef.getDesc())) {
-                    return false;
-                }
+            if (VectorizedUtil.isVectorized()
+                    && childSlotRef.getDesc().getSlotOffset() != setOpSlotRef.getDesc().getSlotOffset()) {

Review Comment:
   maybe it it better to only check type and nullable when use vectorized engine, then we have more chance to do passthrough



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org