You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/04/10 15:13:00 UTC
[jira] [Commented] (AIRFLOW-4269) For-lop in
jobs._process_task_instances can be faster by breaking from unnecessary
steps
[ https://issues.apache.org/jira/browse/AIRFLOW-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814533#comment-16814533 ]
ASF GitHub Bot commented on AIRFLOW-4269:
-----------------------------------------
XD-DENG commented on pull request #5076: [AIRFLOW-4269] Minor acceleration of jobs._process_task_instances()
URL: https://github.com/apache/airflow/pull/5076
### Jira
- https://issues.apache.org/jira/browse/AIRFLOW-4269
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
`continue` here should be a `break`.
When `len(active_dag_runs) >= dag.max_active_runs`, the following part of the for-loop will give the same result and result in a `continue` again and again, while doing nothing. We should use a `break` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> For-lop in jobs._process_task_instances can be faster by breaking from unnecessary steps
> ----------------------------------------------------------------------------------------
>
> Key: AIRFLOW-4269
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4269
> Project: Apache Airflow
> Issue Type: Improvement
> Affects Versions: 1.10.2
> Reporter: Xiaodong DENG
> Assignee: Xiaodong DENG
> Priority: Minor
>
> [https://github.com/apache/airflow/blob/64331aa5b90c44a3a22631d0ed168c44842a1fc8/airflow/jobs.py#L923] is a "continue" while it should be a break.
> When *len(active_dag_runs) >= dag.max_active_runs* , the following part of the for-loop will give the same result and result in a "continue" again and again, doing nothing.
> We should use a "break" here.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)