You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/07 14:21:48 UTC
[GitHub] [hudi] dongkelun commented on a change in pull request #4632: [HUDI-3272] If `mode==ignore && tableExists`, do not execute write logic and sync hive
dongkelun commented on a change in pull request #4632:
URL: https://github.com/apache/hudi/pull/4632#discussion_r800702744
##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -366,51 +366,51 @@ object HoodieSparkSqlWriter {
schema = HoodieAvroUtils.getNullSchema.toString
}
- // Handle various save modes
if (mode == SaveMode.Ignore && tableExists) {
log.warn(s"hoodie table at $basePath already exists. Ignoring & not performing actual writes.")
false
Review comment:
It will return false and exit from here, and the same logic is used in `HoodieSparkSqlWriter.write`.But the original version will not directly return false, and will continue to execute the following code logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org