You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/13 13:21:11 UTC
[GitHub] [incubator-eventmesh] jonyangx opened a new pull request, #2580: [ISSUE #2534] Method stores return result in local before immediately returning it [BaseRequestBody]
jonyangx opened a new pull request, #2580:
URL: https://github.com/apache/incubator-eventmesh/pull/2580
Fixes #2354 .
### Motivation
Method stores return result in local before immediately returning it [BaseRequestBody]
### Modifications
refactor eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/BaseRequestBody.java
### Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? (not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #2580: [ISSUE #2534] Method stores return result in local before immediately returning it [BaseRequestBody]
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2580:
URL: https://github.com/apache/incubator-eventmesh/pull/2580#issuecomment-1348617576
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/2580?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2580](https://codecov.io/gh/apache/incubator-eventmesh/pull/2580?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4f53248) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/512728e02a35de991e802ec1a34be14cdb5ae5d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (512728e) will **increase** coverage by `0.41%`.
> The diff coverage is `49.64%`.
> :exclamation: Current head 4f53248 differs from pull request most recent head 58bc73b. Consider uploading reports for the commit 58bc73b to get more accurate results
```diff
@@ Coverage Diff @@
## master #2580 +/- ##
============================================
+ Coverage 11.38% 11.80% +0.41%
- Complexity 877 914 +37
============================================
Files 469 480 +11
Lines 27944 28226 +282
Branches 3031 3040 +9
============================================
+ Hits 3181 3331 +150
- Misses 24478 24601 +123
- Partials 285 294 +9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/2580?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...esh/common/protocol/http/body/BaseRequestBody.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2580/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2JvZHkvQmFzZVJlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...tmesh/connector/qmq/common/EventMeshConstants.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2580/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1xbXEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9jb25uZWN0b3IvcW1xL2NvbW1vbi9FdmVudE1lc2hDb25zdGFudHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...qmq/connector/ConnectorResourceServiceQMQImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2580/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1xbXEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9jb25uZWN0b3IvcW1xL2Nvbm5lY3Rvci9Db25uZWN0b3JSZXNvdXJjZVNlcnZpY2VRTVFJbXBsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...eventmesh/connector/qmq/utils/CloudEventUtils.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2580/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1xbXEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9jb25uZWN0b3IvcW1xL3V0aWxzL0Nsb3VkRXZlbnRVdGlscy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../admin/handler/ShowListenClientByTopicHandler.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2580/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvU2hvd0xpc3RlbkNsaWVudEJ5VG9waWNIYW5kbGVyLmphdmE=) | `12.90% <ø> (ø)` | |
| [...esh/connector/qmq/consumer/QMQPullMessageTask.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2580/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1xbXEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9jb25uZWN0b3IvcW1xL2NvbnN1bWVyL1FNUVB1bGxNZXNzYWdlVGFzay5qYXZh) | `38.09% <38.09%> (ø)` | |
| [...ector/qmq/consumer/BlockingThreadPoolExecutor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2580/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1xbXEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9jb25uZWN0b3IvcW1xL2NvbnN1bWVyL0Jsb2NraW5nVGhyZWFkUG9vbEV4ZWN1dG9yLmphdmE=) | `44.44% <44.44%> (ø)` | |
| [...tmesh/connector/qmq/consumer/QMQThreadFactory.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2580/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1xbXEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9jb25uZWN0b3IvcW1xL2NvbnN1bWVyL1FNUVRocmVhZEZhY3RvcnkuamF2YQ==) | `50.00% <50.00%> (ø)` | |
| [...ntmesh/connector/qmq/producer/QMQProducerImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2580/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1xbXEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9jb25uZWN0b3IvcW1xL3Byb2R1Y2VyL1FNUVByb2R1Y2VySW1wbC5qYXZh) | `50.00% <50.00%> (ø)` | |
| [...ntmesh/connector/qmq/consumer/QMQConsumerImpl.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2580/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1xbXEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9jb25uZWN0b3IvcW1xL2NvbnN1bWVyL1FNUUNvbnN1bWVySW1wbC5qYXZh) | `53.65% <53.65%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/2580/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx closed pull request #2580: [ISSUE #2534] Method stores return result in local before immediately returning it [BaseRequestBody]
Posted by GitBox <gi...@apache.org>.
jonyangx closed pull request #2580: [ISSUE #2534] Method stores return result in local before immediately returning it [BaseRequestBody]
URL: https://github.com/apache/incubator-eventmesh/pull/2580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org