You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Branimir Lambov (Jira)" <ji...@apache.org> on 2021/10/28 13:01:00 UTC

[jira] [Updated] (CASSANDRA-6936) Make all byte representations of types comparable by their unsigned byte representation only

     [ https://issues.apache.org/jira/browse/CASSANDRA-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Branimir Lambov updated CASSANDRA-6936:
---------------------------------------
                        Authors: Branimir Lambov, Dimitar Dimitrov, Jacek Lewandowski  (was: Branimir Lambov)
    Test and Documentation Plan: Unit tests and in-tree documentation are included. 
                         Status: Patch Available  (was: In Progress)

Patch uploaded here: [branch|https://github.com/blambov/cassandra/tree/CASSANDRA-6936] [pull request|https://github.com/apache/cassandra/pull/1294]

Provides an API for converting keys to and from byte-comparable representations. Documentation of the translation is given in the included {{ByteComparable.md}}. The translation is versioned and the patch provides two versions: forward-only translation corresponding to DSE 6's trie-indexed sstable format, and a current bi-directional version that can be freely modified.

The byte-ordered translation is required for trie memtables, trie-based primary indexes and SAI secondary indexes.

> Make all byte representations of types comparable by their unsigned byte representation only
> --------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-6936
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6936
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Legacy/Core
>            Reporter: Benedict Elliott Smith
>            Assignee: Branimir Lambov
>            Priority: Normal
>              Labels: compaction, performance
>             Fix For: 4.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This could be a painful change, but is necessary for implementing a trie-based index, and settling for less would be suboptimal; it also should make comparisons cheaper all-round, and since comparison operations are pretty much the majority of C*'s business, this should be easily felt (see CASSANDRA-6553 and CASSANDRA-6934 for an example of some minor changes with major performance impacts). No copying/special casing/slicing should mean fewer opportunities to introduce performance regressions as well.
> Since I have slated for 3.0 a lot of non-backwards-compatible sstable changes, hopefully this shouldn't be too much more of a burden.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org